You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pdfbox.apache.org by ti...@apache.org on 2019/02/06 07:37:20 UTC

svn commit: r1853050 - /pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDNonTerminalField.java

Author: tilman
Date: Wed Feb  6 07:37:20 2019
New Revision: 1853050

URL: http://svn.apache.org/viewvc?rev=1853050&view=rev
Log:
PDFBOX-4455: empty widget list of non terminal field should be non modifiable

Modified:
    pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDNonTerminalField.java

Modified: pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDNonTerminalField.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDNonTerminalField.java?rev=1853050&r1=1853049&r2=1853050&view=diff
==============================================================================
--- pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDNonTerminalField.java (original)
+++ pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/form/PDNonTerminalField.java Wed Feb  6 07:37:20 2019
@@ -260,7 +260,7 @@ public class PDNonTerminalField extends
     @Override
     public List<PDAnnotationWidget> getWidgets()
     {
-        //TODO shouldn't we return a non modifiable list?
-        return Collections.emptyList();
+        List<PDAnnotationWidget> emptyList = Collections.emptyList();
+        return Collections.unmodifiableList(emptyList);
     }
 }