You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2022/05/22 20:22:17 UTC
[commons-pool] 03/03: Normalize inline comments
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-pool.git
commit 3b24dad07c9c9887d75bb64f43a4fd4bd0d6268d
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Sun May 22 16:22:09 2022 -0400
Normalize inline comments
---
.../apache/commons/pool2/TestKeyedObjectPool.java | 22 +++++++++++-----------
.../org/apache/commons/pool2/TestObjectPool.java | 14 +++++++-------
2 files changed, 18 insertions(+), 18 deletions(-)
diff --git a/src/test/java/org/apache/commons/pool2/TestKeyedObjectPool.java b/src/test/java/org/apache/commons/pool2/TestKeyedObjectPool.java
index ef955579..468ba103 100644
--- a/src/test/java/org/apache/commons/pool2/TestKeyedObjectPool.java
+++ b/src/test/java/org/apache/commons/pool2/TestKeyedObjectPool.java
@@ -520,7 +520,7 @@ public abstract class TestKeyedObjectPool {
expectedMethods.add(new MethodCall("passivateObject", KEY, ZERO));
assertEquals(expectedMethods, factory.getMethodCalls());
- //// Test exception handling of addObject
+ // Test exception handling of addObject
reset(pool, factory, expectedMethods);
// makeObject Exceptions should be propagated to client code from addObject
@@ -557,7 +557,7 @@ public abstract class TestKeyedObjectPool {
((GenericKeyedObjectPool<Object, Object, PrivateException>) pool).setTestOnBorrow(true);
}
- /// Test correct behavior code paths
+ // Test correct behavior code paths
// existing idle object should be activated and validated
pool.addObject(KEY);
@@ -568,7 +568,7 @@ public abstract class TestKeyedObjectPool {
assertEquals(expectedMethods, factory.getMethodCalls());
pool.returnObject(KEY, obj);
- //// Test exception handling of borrowObject
+ // Test exception handling of borrowObject
reset(pool, factory, expectedMethods);
// makeObject Exceptions should be propagated to client code from borrowObject
@@ -630,11 +630,11 @@ public abstract class TestKeyedObjectPool {
}
final List<MethodCall> expectedMethods = new ArrayList<>();
- /// Test correct behavior code paths
+ // Test correct behavior code paths
pool.addObjects(KEY, 5);
pool.clear();
- //// Test exception handling clear should swallow destroy object failures
+ // Test exception handling clear should swallow destroy object failures
reset(pool, factory, expectedMethods);
factory.setDestroyObjectFail(true);
pool.addObjects(KEY, 5);
@@ -654,11 +654,11 @@ public abstract class TestKeyedObjectPool {
}
final List<MethodCall> expectedMethods = new ArrayList<>();
- /// Test correct behavior code paths
+ // Test correct behavior code paths
pool.addObjects(KEY, 5);
pool.close();
- //// Test exception handling close should swallow failures
+ // Test exception handling close should swallow failures
try (final KeyedObjectPool<Object, Object, PrivateException> pool2 = makeEmptyPool(factory)) {
reset(pool2, factory, expectedMethods);
factory.setDestroyObjectFail(true);
@@ -678,7 +678,7 @@ public abstract class TestKeyedObjectPool {
final List<MethodCall> expectedMethods = new ArrayList<>();
Object obj;
- /// Test correct behavior code paths
+ // Test correct behavior code paths
obj = pool.borrowObject(KEY);
clear(factory, expectedMethods);
@@ -688,7 +688,7 @@ public abstract class TestKeyedObjectPool {
expectedMethods.add(new MethodCall("destroyObject", KEY, obj));
assertEquals(expectedMethods, factory.getMethodCalls());
- //// Test exception handling of invalidateObject
+ // Test exception handling of invalidateObject
reset(pool, factory, expectedMethods);
final Object obj2 = pool.borrowObject(KEY);
clear(factory, expectedMethods);
@@ -712,7 +712,7 @@ public abstract class TestKeyedObjectPool {
final List<MethodCall> expectedMethods = new ArrayList<>();
Object obj;
- /// Test correct behavior code paths
+ // Test correct behavior code paths
obj = pool.borrowObject(KEY);
clear(factory, expectedMethods);
@@ -721,7 +721,7 @@ public abstract class TestKeyedObjectPool {
expectedMethods.add(new MethodCall("passivateObject", KEY, obj));
assertEquals(expectedMethods, factory.getMethodCalls());
- //// Test exception handling of returnObject
+ // Test exception handling of returnObject
reset(pool, factory, expectedMethods);
// passivateObject should swallow exceptions and not add the object to the pool
diff --git a/src/test/java/org/apache/commons/pool2/TestObjectPool.java b/src/test/java/org/apache/commons/pool2/TestObjectPool.java
index 4b9a5b9f..7eb9107f 100644
--- a/src/test/java/org/apache/commons/pool2/TestObjectPool.java
+++ b/src/test/java/org/apache/commons/pool2/TestObjectPool.java
@@ -138,7 +138,7 @@ public abstract class TestObjectPool {
expectedMethods.add(new MethodCall("passivateObject", ZERO));
assertEquals(expectedMethods, factory.getMethodCalls());
- //// Test exception handling of addObject
+ // Test exception handling of addObject
reset(pool, factory, expectedMethods);
// makeObject Exceptions should be propagated to client code from addObject
@@ -178,7 +178,7 @@ public abstract class TestObjectPool {
final List<MethodCall> expectedMethods = new ArrayList<>();
Object obj;
- /// Test correct behavior code paths
+ // Test correct behavior code paths
// existing idle object should be activated and validated
pool.addObject();
@@ -189,7 +189,7 @@ public abstract class TestObjectPool {
assertEquals(expectedMethods, factory.getMethodCalls());
pool.returnObject(obj);
- //// Test exception handling of borrowObject
+ // Test exception handling of borrowObject
reset(pool, factory, expectedMethods);
// makeObject Exceptions should be propagated to client code from borrowObject
@@ -246,11 +246,11 @@ public abstract class TestObjectPool {
}
final List<MethodCall> expectedMethods = new ArrayList<>();
- /// Test correct behavior code paths
+ // Test correct behavior code paths
pool.addObjects(5);
pool.clear();
- //// Test exception handling clear should swallow destroy object failures
+ // Test exception handling clear should swallow destroy object failures
reset(pool, factory, expectedMethods);
factory.setDestroyObjectFail(true);
pool.addObjects(5);
@@ -332,7 +332,7 @@ public abstract class TestObjectPool {
final List<MethodCall> expectedMethods = new ArrayList<>();
Object obj;
- /// Test correct behavior code paths
+ // Test correct behavior code paths
obj = pool.borrowObject();
clear(factory, expectedMethods);
@@ -346,7 +346,7 @@ public abstract class TestObjectPool {
expectedMethods.add(new MethodCall("passivateObject", obj));
assertEquals(expectedMethods, factory.getMethodCalls());
- //// Test exception handling of returnObject
+ // Test exception handling of returnObject
reset(pool, factory, expectedMethods);
pool.addObject();
pool.addObject();