You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "pandaapo (via GitHub)" <gi...@apache.org> on 2023/05/07 06:36:51 UTC
[GitHub] [eventmesh] pandaapo opened a new pull request, #3875: [ISSUE #3874]Add a load balance strategy: source ip hash
pandaapo opened a new pull request, #3875:
URL: https://github.com/apache/eventmesh/pull/3875
Fixes #3874.
### Motivation
Add a load balance strategy: source ip hash. Make the same client machine always arrive at the same server.
### Modifications
Add a new LoadBalanceSelector for implementing source ip hash algorithm.
Add unit test for new LoadBalanceSelector.
### Documentation
- Does this pull request introduce a new feature? yes
- If yes, how is the feature documented? JavaDocs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [eventmesh] codecov[bot] commented on pull request #3875: [ISSUE #3874]Add a load balance strategy: source ip hash
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3875:
URL: https://github.com/apache/eventmesh/pull/3875#issuecomment-1539605224
## [Codecov](https://app.codecov.io/gh/apache/eventmesh/pull/3875?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3875](https://app.codecov.io/gh/apache/eventmesh/pull/3875?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9e60028) into [master](https://app.codecov.io/gh/apache/eventmesh/commit/d976bbf635b7f4bcdc032b1af5da175b6246e4b3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d976bbf) will **increase** coverage by `0.09%`.
> The diff coverage is `32.25%`.
> :exclamation: Current head 9e60028 differs from pull request most recent head bbc6e5b. Consider uploading reports for the commit bbc6e5b to get more accurate results
```diff
@@ Coverage Diff @@
## master #3875 +/- ##
============================================
+ Coverage 13.91% 14.00% +0.09%
- Complexity 1291 1303 +12
============================================
Files 572 572
Lines 28888 28884 -4
Branches 2816 2806 -10
============================================
+ Hits 4019 4045 +26
+ Misses 24496 24467 -29
+ Partials 373 372 -1
```
| [Impacted Files](https://app.codecov.io/gh/apache/eventmesh/pull/3875?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...pache/eventmesh/common/EventMeshThreadFactory.java](https://app.codecov.io/gh/apache/eventmesh/pull/3875?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9FdmVudE1lc2hUaHJlYWRGYWN0b3J5LmphdmE=) | `69.56% <ø> (ø)` | |
| [.../eventmesh/runtime/core/protocol/RetryContext.java](https://app.codecov.io/gh/apache/eventmesh/pull/3875?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvUmV0cnlDb250ZXh0LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...ore/protocol/grpc/producer/SendMessageContext.java](https://app.codecov.io/gh/apache/eventmesh/pull/3875?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvZ3JwYy9wcm9kdWNlci9TZW5kTWVzc2FnZUNvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...e/core/protocol/grpc/push/AbstractPushRequest.java](https://app.codecov.io/gh/apache/eventmesh/pull/3875?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvZ3JwYy9wdXNoL0Fic3RyYWN0UHVzaFJlcXVlc3QuamF2YQ==) | `0.00% <ø> (ø)` | |
| [.../runtime/core/protocol/grpc/retry/GrpcRetryer.java](https://app.codecov.io/gh/apache/eventmesh/pull/3875?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvZ3JwYy9yZXRyeS9HcnBjUmV0cnllci5qYXZh) | `0.00% <ø> (ø)` | |
| [...ore/protocol/http/producer/SendMessageContext.java](https://app.codecov.io/gh/apache/eventmesh/pull/3875?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvaHR0cC9wcm9kdWNlci9TZW5kTWVzc2FnZUNvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...re/protocol/http/push/AbstractHTTPPushRequest.java](https://app.codecov.io/gh/apache/eventmesh/pull/3875?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvaHR0cC9wdXNoL0Fic3RyYWN0SFRUUFB1c2hSZXF1ZXN0LmphdmE=) | `0.00% <ø> (ø)` | |
| [.../core/protocol/http/push/AsyncHTTPPushRequest.java](https://app.codecov.io/gh/apache/eventmesh/pull/3875?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvaHR0cC9wdXNoL0FzeW5jSFRUUFB1c2hSZXF1ZXN0LmphdmE=) | `0.00% <ø> (ø)` | |
| [.../runtime/core/protocol/http/retry/HttpRetryer.java](https://app.codecov.io/gh/apache/eventmesh/pull/3875?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvaHR0cC9yZXRyeS9IdHRwUmV0cnllci5qYXZh) | `0.00% <ø> (ø)` | |
| [...time/core/protocol/tcp/client/session/Session.java](https://app.codecov.io/gh/apache/eventmesh/pull/3875?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvdGNwL2NsaWVudC9zZXNzaW9uL1Nlc3Npb24uamF2YQ==) | `2.40% <0.00%> (+0.28%)` | :arrow_up: |
| ... and [13 more](https://app.codecov.io/gh/apache/eventmesh/pull/3875?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
... and [7 files with indirect coverage changes](https://app.codecov.io/gh/apache/eventmesh/pull/3875/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #3874]Add a load balance strategy: source ip hash (eventmesh)
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #3875:
URL: https://github.com/apache/eventmesh/pull/3875#issuecomment-2070568931
## [Codecov](https://app.codecov.io/gh/apache/eventmesh/pull/3875?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: Patch coverage is `64.44444%` with `16 lines` in your changes are missing coverage. Please review.
> Project coverage is 14.01%. Comparing base [(`0ce8d57`)](https://app.codecov.io/gh/apache/eventmesh/commit/0ce8d57e6a87890354fdc0643f06aae4acb6cc41?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`9e60028`)](https://app.codecov.io/gh/apache/eventmesh/pull/3875?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 431 commits behind head on master.
> :exclamation: Current head 9e60028 differs from pull request most recent head 78c6b51. Consider uploading reports for the commit 78c6b51 to get more accurate results
| [Files](https://app.codecov.io/gh/apache/eventmesh/pull/3875?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...entmesh/client/http/util/HttpLoadBalanceUtils.java](https://app.codecov.io/gh/apache/eventmesh/pull/3875?src=pr&el=tree&filepath=eventmesh-sdk-java%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Feventmesh%2Fclient%2Fhttp%2Futil%2FHttpLoadBalanceUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLXNkay1qYXZhL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY2xpZW50L2h0dHAvdXRpbC9IdHRwTG9hZEJhbGFuY2VVdGlscy5qYXZh) | 0.00% | [12 Missing :warning: ](https://app.codecov.io/gh/apache/eventmesh/pull/3875?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...n/loadbalance/SourceIPHashLoadBalanceSelector.java](https://app.codecov.io/gh/apache/eventmesh/pull/3875?src=pr&el=tree&filepath=eventmesh-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Feventmesh%2Fcommon%2Floadbalance%2FSourceIPHashLoadBalanceSelector.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9sb2FkYmFsYW5jZS9Tb3VyY2VJUEhhc2hMb2FkQmFsYW5jZVNlbGVjdG9yLmphdmE=) | 88.00% | [2 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/eventmesh/pull/3875?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ache/eventmesh/common/utils/CommonStringUtils.java](https://app.codecov.io/gh/apache/eventmesh/pull/3875?src=pr&el=tree&filepath=eventmesh-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Feventmesh%2Fcommon%2Futils%2FCommonStringUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi91dGlscy9Db21tb25TdHJpbmdVdGlscy5qYXZh) | 83.33% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/eventmesh/pull/3875?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #3875 +/- ##
============================================
- Coverage 14.24% 14.01% -0.23%
+ Complexity 1320 1303 -17
============================================
Files 579 572 -7
Lines 28967 28891 -76
Branches 2802 2818 +16
============================================
- Hits 4125 4049 -76
- Misses 24450 24469 +19
+ Partials 392 373 -19
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/eventmesh/pull/3875?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #3874]Add a load balance strategy: source ip hash (eventmesh)
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #3875:
URL: https://github.com/apache/eventmesh/pull/3875#issuecomment-2070568370
It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback.
If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org