[GitHub] [hudi] zhedoubushishi commented on pull request #2833: [HUDI-89] Add configOption & refactor Hudi configuration framework

[GitBox <gi...@apache.org>]

zhedoubushishi commented on pull request #2833:
URL: https://github.com/apache/hudi/pull/2833#issuecomment-832882768


   > I recommend checking out:
   > 
   > * https://github.com/apache/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
   > * https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/SparkConf.scala
   > 
   > It has some good pieces we can adopt and specially as we will move towards a file based configuration. Some things that just standout based on quick look, but you can dig deeper:
   > 
   > * Specifying version from which that property is supported
   > * Whether the property is an internal config
   > * Differentiate between Alternate and Deprecated configs. For ex: Hudi table name has alternatives
   
   Good point! Version, Alternate & Deprecated are definitely something we can add. Will try to support them.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org