You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by se...@james.apache.org on 2004/09/17 06:43:37 UTC

[jira] Created: (JAMES-323) using toUppercase, toLowerCase, equalsIgnoreCase without specifying the locale is a bug

Message:

  A new issue has been created in JIRA.

---------------------------------------------------------------------
View the issue:
  http://issues.apache.org/jira/browse/JAMES-323

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: JAMES-323
    Summary: using toUppercase, toLowerCase, equalsIgnoreCase without specifying the locale is a bug
       Type: Bug

     Status: Unassigned
   Priority: Minor

    Project: James

   Assignee: 
   Reporter: Hontvari Jozsef

    Created: Thu, 16 Sep 2004 9:43 PM
    Updated: Thu, 16 Sep 2004 9:43 PM
Environment: turkish locale

Description:
Subject tells all, converting case in a server application without specifying an explicit locale is almost always a bug. People may assume that this works for ASCII characters, and usually does, but not in all locale. All such code were fixed about two years ago, but I read the JDJ newsletter article and wondered what is the current status of James, and indeed I found a few new places, where the same bug reappeared:
toUppercase():
-MBoxMailRepository.java

toLowercase():
-CommandListservManager.java
-RemoteDelivery.java
-SenderHostIs.java

I didn't find equalsIgnoreCase calls.

All of the above should be replaced with toLowercase(Locale.ENGLISH) or toUppercase(Locale.ENGLISH)


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


[jira] Resolved: (JAMES-323) using toUppercase, toLowerCase, equalsIgnoreCase without specifying the locale is a bug

Posted by "Stefano Bagnara (JIRA)" <se...@james.apache.org>.
     [ http://issues.apache.org/jira/browse/JAMES-323?page=all ]
     
Stefano Bagnara resolved JAMES-323:
-----------------------------------

    Fix Version: 2.2.1
     Resolution: Fixed

Used Locale.US (as it was already used instead of Locale.ENGLISH).

> using toUppercase, toLowerCase, equalsIgnoreCase without specifying the locale is a bug
> ---------------------------------------------------------------------------------------
>
>          Key: JAMES-323
>          URL: http://issues.apache.org/jira/browse/JAMES-323
>      Project: James
>         Type: Bug
>  Environment: turkish locale
>     Reporter: Hontvari Jozsef
>     Assignee: Stefano Bagnara
>     Priority: Minor
>      Fix For: 2.2.1

>
> Subject tells all, converting case in a server application without specifying an explicit locale is almost always a bug. People may assume that this works for ASCII characters, and usually does, but not in all locale. All such code were fixed about two years ago, but I read the JDJ newsletter article and wondered what is the current status of James, and indeed I found a few new places, where the same bug reappeared:
> toUppercase():
> -MBoxMailRepository.java
> toLowercase():
> -CommandListservManager.java
> -RemoteDelivery.java
> -SenderHostIs.java
> I didn't find equalsIgnoreCase calls.
> All of the above should be replaced with toLowercase(Locale.ENGLISH) or toUppercase(Locale.ENGLISH)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


[jira] Assigned: (JAMES-323) using toUppercase, toLowerCase, equalsIgnoreCase without specifying the locale is a bug

Posted by "Stefano Bagnara (JIRA)" <se...@james.apache.org>.
     [ http://issues.apache.org/jira/browse/JAMES-323?page=all ]

Stefano Bagnara reassigned JAMES-323:
-------------------------------------

    Assign To: Stefano Bagnara

> using toUppercase, toLowerCase, equalsIgnoreCase without specifying the locale is a bug
> ---------------------------------------------------------------------------------------
>
>          Key: JAMES-323
>          URL: http://issues.apache.org/jira/browse/JAMES-323
>      Project: James
>         Type: Bug
>  Environment: turkish locale
>     Reporter: Hontvari Jozsef
>     Assignee: Stefano Bagnara
>     Priority: Minor

>
> Subject tells all, converting case in a server application without specifying an explicit locale is almost always a bug. People may assume that this works for ASCII characters, and usually does, but not in all locale. All such code were fixed about two years ago, but I read the JDJ newsletter article and wondered what is the current status of James, and indeed I found a few new places, where the same bug reappeared:
> toUppercase():
> -MBoxMailRepository.java
> toLowercase():
> -CommandListservManager.java
> -RemoteDelivery.java
> -SenderHostIs.java
> I didn't find equalsIgnoreCase calls.
> All of the above should be replaced with toLowercase(Locale.ENGLISH) or toUppercase(Locale.ENGLISH)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org