You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/03/12 16:13:05 UTC

[GitHub] [pulsar] StevenLuMT commented on a change in pull request #12025: [feature] Strict bookie affinity group strategy

StevenLuMT commented on a change in pull request #12025:
URL: https://github.com/apache/pulsar/pull/12025#discussion_r825320297



##########
File path: pulsar-broker-common/src/main/java/org/apache/pulsar/bookie/rackawareness/IsolatedBookieEnsemblePlacementPolicy.java
##########
@@ -256,10 +291,21 @@ private static String castToString(Object obj) {
                         if (bookieGroup != null && !bookieGroup.isEmpty()) {
                             for (String bookieAddress : bookieGroup.keySet()) {
                                 blacklistedBookies.remove(BookieId.parse(bookieAddress));
+                                totalAvailableBookiesFromPrimaryAndSecondary += 1;
                             }
                         }
                     }
                 }
+                if (totalAvailableBookiesFromPrimaryAndSecondary < ensembleSize) {
+                    log.info(

Review comment:
       use log.warn? I think 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org