You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/12/30 04:06:46 UTC
[GitHub] [shardingsphere-on-cloud] xuanyuan300 opened a new issue, #168: [Discussion] `Stragegy` changing for `Deployment` configuration of ShardingSphere-Proxy
xuanyuan300 opened a new issue, #168:
URL: https://github.com/apache/shardingsphere-on-cloud/issues/168
## Background
Currently, in the `Deployment` configuration generated by `ShardingSphere Operator` for `ShardingSphere-Proxy`, the Strategy is `v1.RecreateDeploymentStrategyType`. This will cause the `proxy pod` to be deleted and rebuilt when the user updates, cause a temporary interruption of the user connect to the proxy.
## Plan
The `Strategy` of the `Deployment` for `SahrdingSphere-Proxy` should be changed to `RollingUpdateDeploymentStrategyType` to avoid connetcion lost cause temporary interruption
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-on-cloud] mlycore commented on issue #168: [Discussion] `Stragegy` changing for `Deployment` configuration of ShardingSphere-Proxy
Posted by GitBox <gi...@apache.org>.
mlycore commented on issue #168:
URL: https://github.com/apache/shardingsphere-on-cloud/issues/168#issuecomment-1373022385
solved in #172
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-on-cloud] mlycore closed issue #168: [Discussion] `Stragegy` changing for `Deployment` configuration of ShardingSphere-Proxy
Posted by GitBox <gi...@apache.org>.
mlycore closed issue #168: [Discussion] `Stragegy` changing for `Deployment` configuration of ShardingSphere-Proxy
URL: https://github.com/apache/shardingsphere-on-cloud/issues/168
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-on-cloud] mlycore commented on issue #168: [Discussion] `Stragegy` changing for `Deployment` configuration of ShardingSphere-Proxy
Posted by GitBox <gi...@apache.org>.
mlycore commented on issue #168:
URL: https://github.com/apache/shardingsphere-on-cloud/issues/168#issuecomment-1367713724
LGTM. What will be the default upgrading setup, like maxUnavailable and maxSurge?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-on-cloud] mlycore commented on issue #168: [Discussion] `Stragegy` changing for `Deployment` configuration of ShardingSphere-Proxy
Posted by GitBox <gi...@apache.org>.
mlycore commented on issue #168:
URL: https://github.com/apache/shardingsphere-on-cloud/issues/168#issuecomment-1372476226
In pr #172, it changes default `Strategy` from `Recreate` to `RollingUpdate` and only supports this kind. Parameters used in `RollingUpdate` are not proposed in CRD `ShardingSphereProxy`, because it will be deprecated in future release.
So users could custom this `maxSurge` and `maxUnavailable` via annotations `shardingsphereproxy.shardingsphere.org/rolling-update-max-surge` and `shardingsphereproxy.shardingsphere.org/rolling-update-max-unavailable` respectively.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-on-cloud] xuanyuan300 commented on issue #168: [Discussion] `Stragegy` changing for `Deployment` configuration of ShardingSphere-Proxy
Posted by GitBox <gi...@apache.org>.
xuanyuan300 commented on issue #168:
URL: https://github.com/apache/shardingsphere-on-cloud/issues/168#issuecomment-1372057828
I think `maxUnavailable` should be '0' and `maxSurge` should be '1' for stable `rolling update`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org