You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/07/15 23:51:46 UTC

[GitHub] [incubator-seatunnel] zhaomin1423 opened a new pull request, #2186: update the condition to 1 = 0 about get table operation

zhaomin1423 opened a new pull request, #2186:
URL: https://github.com/apache/incubator-seatunnel/pull/2186

   <!--
   
   Thank you for contributing to SeaTunnel! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
   
     - Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
   
     - Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
   
   -->
   
   ## Purpose of this pull request
   
   <!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
   The data need not to acquire, so the 1 = 0 have more performance.
   
   ## Check list
   
   * [ ] Code changed are covered with tests, or it does not need tests for reason:
   * [ ] If any new Jar binary package adding in your PR, please add License Notice according
     [New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
   * [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] zhaomin1423 commented on pull request #2186: update the condition to 1 = 0 about get table operation

Posted by GitBox <gi...@apache.org>.
zhaomin1423 commented on PR #2186:
URL: https://github.com/apache/incubator-seatunnel/pull/2186#issuecomment-1188542040

   Thanks for your review. @CalvinKirs @ashulin 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] CalvinKirs commented on pull request #2186: update the condition to 1 = 0 about get table operation

Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on PR #2186:
URL: https://github.com/apache/incubator-seatunnel/pull/2186#issuecomment-1188559529

   Hi @zhaomin1423 , thanks for your contribution  🎉 . If you want to contribute but could not find the issue, maybe you could start https://github.com/apache/incubator-seatunnel/issues?q=is%3Aopen+is%3Aissue+label%3A%22volunteer+wanted%22, Looking forward to your next contribution.If you have any questions, dev email exchange or contact me (WeChat: Kris Evil)A private conversation. We'd rather have a public conversation


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] CalvinKirs merged pull request #2186: update the condition to 1 = 0 about get table operation

Posted by GitBox <gi...@apache.org>.
CalvinKirs merged PR #2186:
URL: https://github.com/apache/incubator-seatunnel/pull/2186


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] CalvinKirs commented on pull request #2186: update the condition to 1 = 0 about get table operation

Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on PR #2186:
URL: https://github.com/apache/incubator-seatunnel/pull/2186#issuecomment-1186068928

   @ashulin Hi, PTAL,thx


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org