You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2018/06/25 18:07:59 UTC

Review Request 67723: Added a principal field to `Create[Volume|Disk]` operations.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67723/
-----------------------------------------------------------

Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.


Repository: mesos


Description
-------

In Mesos we customary add a principal to fields created by authorized
operations and then on destroy authorize that the triggering principal
can perform the operations on resources created by that principal,
e.g., for a `RESERVE` operation we would expect the `principal` field
of the `ReservationInfo` to be set.

For new-style operation we supply the source resources of an operation
as opposed to e.g., a `RESERVE` operation where the target resources
would be given in the operation. This makes it necessary to pass the
principal explicitly in the operation.

This patch adds a principal field to the `CreateVolume` and
`CreateBlock` operations.


Diffs
-----

  include/mesos/mesos.proto 463e6adcdf14115b2f21270bb1fd9c45e1b67cc3 
  include/mesos/v1/mesos.proto 8eaad9c4b2a9cdd527922a004b0f7dd0dc58a7f1 


Diff: https://reviews.apache.org/r/67723/diff/1/


Testing
-------

`sudo make check`


Thanks,

Benjamin Bannier