You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2015/11/13 02:20:58 UTC
Re: Review Request 40169: [4/7] Added 'Master::authorize{Destroy,
Create}Volume' to create/destroy persistent volumes.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40169/
-----------------------------------------------------------
(Updated Nov. 13, 2015, 1:20 a.m.)
Review request for mesos, Jie Yu, Michael Park, and Neil Conway.
Summary (updated)
-----------------
[4/7] Added 'Master::authorize{Destroy,Create}Volume' to create/destroy persistent volumes.
Bugs: MESOS-3065
https://issues.apache.org/jira/browse/MESOS-3065
Repository: mesos
Description
-------
Added 'Master::authorize{Destroy,Create}Volume' to create/destroy persistent volumes.
Diffs
-----
src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2
src/master/master.cpp 7bac0fea4bcd040307fdfdcd002387d5baee46d1
Diff: https://reviews.apache.org/r/40169/diff/
Testing
-------
This is the fourth in a chain of 6 patches. `make check` was used to test after all patches were applied.
Note that this chain of patches touches many of the same files as another chain beginning with Review #39985 and ending with Review #39989, which is currently in review as well. To avoid conflicts, the beginning of this chain begins on top of Review #39989.
Thanks,
Greg Mann
Re: Review Request 40169: [4/7] Added 'Master::authorize{Destroy,
Create}Volume' to create/destroy persistent volumes.
Posted by Greg Mann <gr...@mesosphere.io>.
> On Nov. 13, 2015, 10:52 a.m., Neil Conway wrote:
> > src/master/master.cpp, line 3128
> > <https://reviews.apache.org/r/40169/diff/1/?file=1124678#file1124678line3128>
> >
> > Seems like this change shouldn't be included in this review. i.e., the state of the tree after any patch in a patch chain should still be correct.
Good call, thanks Neil.
- Greg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40169/#review106396
-----------------------------------------------------------
On Nov. 13, 2015, 6:30 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40169/
> -----------------------------------------------------------
>
> (Updated Nov. 13, 2015, 6:30 p.m.)
>
>
> Review request for mesos, Jie Yu, Michael Park, and Neil Conway.
>
>
> Bugs: MESOS-3065
> https://issues.apache.org/jira/browse/MESOS-3065
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added 'Master::authorize{Destroy,Create}Volume' to create/destroy persistent volumes.
>
>
> Diffs
> -----
>
> src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2
> src/master/master.cpp 7bac0fea4bcd040307fdfdcd002387d5baee46d1
>
> Diff: https://reviews.apache.org/r/40169/diff/
>
>
> Testing
> -------
>
> This is the fourth in a chain of 7 patches. `make check` was used to test after all patches were applied.
>
> Note that this chain of patches touches many of the same files as another chain beginning with Review #39985 and ending with Review #39989, which is currently in review as well. To avoid conflicts, the beginning of this chain begins on top of Review #39989.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 40169: [4/7] Added 'Master::authorize{Destroy,
Create}Volume' to create/destroy persistent volumes.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40169/#review106396
-----------------------------------------------------------
src/master/master.cpp
<https://reviews.apache.org/r/40169/#comment165140>
Seems like this change shouldn't be included in this review. i.e., the state of the tree after any patch in a patch chain should still be correct.
- Neil Conway
On Nov. 13, 2015, 1:21 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40169/
> -----------------------------------------------------------
>
> (Updated Nov. 13, 2015, 1:21 a.m.)
>
>
> Review request for mesos, Jie Yu, Michael Park, and Neil Conway.
>
>
> Bugs: MESOS-3065
> https://issues.apache.org/jira/browse/MESOS-3065
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added 'Master::authorize{Destroy,Create}Volume' to create/destroy persistent volumes.
>
>
> Diffs
> -----
>
> src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2
> src/master/master.cpp 7bac0fea4bcd040307fdfdcd002387d5baee46d1
>
> Diff: https://reviews.apache.org/r/40169/diff/
>
>
> Testing
> -------
>
> This is the fourth in a chain of 7 patches. `make check` was used to test after all patches were applied.
>
> Note that this chain of patches touches many of the same files as another chain beginning with Review #39985 and ending with Review #39989, which is currently in review as well. To avoid conflicts, the beginning of this chain begins on top of Review #39989.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 40169: [4/7] Added 'Master::authorize{Destroy,
Create}Volume' to create/destroy persistent volumes.
Posted by Greg Mann <gr...@mesosphere.io>.
> On Dec. 16, 2015, 2:36 p.m., Alexander Rukletsov wrote:
> > src/master/master.cpp, lines 2870-2871
> > <https://reviews.apache.org/r/40169/diff/4/?file=1156212#file1156212line2870>
> >
> > Looks like a copy-paste-induced typo slipped in : ), I believe you mean "volume is created".
:double facepalm:
Thanks!! :-D
- Greg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40169/#review110656
-----------------------------------------------------------
On Dec. 17, 2015, 12:29 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40169/
> -----------------------------------------------------------
>
> (Updated Dec. 17, 2015, 12:29 a.m.)
>
>
> Review request for mesos, Jie Yu, Michael Park, and Neil Conway.
>
>
> Bugs: MESOS-4179
> https://issues.apache.org/jira/browse/MESOS-4179
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added 'Master::authorize{Destroy,Create}Volume' to create/destroy persistent volumes.
>
>
> Diffs
> -----
>
> src/master/master.hpp 9aa548aa6e159046c94e4ec96f631ea8b3bfd5d8
> src/master/master.cpp 0d1482279c68f2a4a27dabaf28774769a5d515c4
>
> Diff: https://reviews.apache.org/r/40169/diff/
>
>
> Testing
> -------
>
> This is the fourth in a chain of 7 patches. `make check` was used to test after all patches were applied.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 40169: [4/7] Added 'Master::authorize{Destroy,
Create}Volume' to create/destroy persistent volumes.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40169/#review110656
-----------------------------------------------------------
src/master/master.cpp (lines 2870 - 2871)
<https://reviews.apache.org/r/40169/#comment170692>
Looks like a copy-paste-induced typo slipped in : ), I believe you mean "volume is created".
- Alexander Rukletsov
On Dec. 15, 2015, 9:18 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40169/
> -----------------------------------------------------------
>
> (Updated Dec. 15, 2015, 9:18 p.m.)
>
>
> Review request for mesos, Jie Yu, Michael Park, and Neil Conway.
>
>
> Bugs: MESOS-4179
> https://issues.apache.org/jira/browse/MESOS-4179
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added 'Master::authorize{Destroy,Create}Volume' to create/destroy persistent volumes.
>
>
> Diffs
> -----
>
> src/master/master.hpp 4683fa542a740f9a0b80fff7fbe0e63ec66266f2
> src/master/master.cpp 953fa4f14929581b226a7e27d30aea7a5aa1fd7c
>
> Diff: https://reviews.apache.org/r/40169/diff/
>
>
> Testing
> -------
>
> This is the fourth in a chain of 7 patches. `make check` was used to test after all patches were applied.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 40169: [4/7] Added 'Master::authorize{Destroy,
Create}Volume' to create/destroy persistent volumes.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40169/#review111064
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Dec. 17, 2015, 12:29 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40169/
> -----------------------------------------------------------
>
> (Updated Dec. 17, 2015, 12:29 a.m.)
>
>
> Review request for mesos, Jie Yu, Michael Park, and Neil Conway.
>
>
> Bugs: MESOS-4179
> https://issues.apache.org/jira/browse/MESOS-4179
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added 'Master::authorize{Destroy,Create}Volume' to create/destroy persistent volumes.
>
>
> Diffs
> -----
>
> src/master/master.hpp 9aa548aa6e159046c94e4ec96f631ea8b3bfd5d8
> src/master/master.cpp 0d1482279c68f2a4a27dabaf28774769a5d515c4
>
> Diff: https://reviews.apache.org/r/40169/diff/
>
>
> Testing
> -------
>
> This is the fourth in a chain of 7 patches. `make check` was used to test after all patches were applied.
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 40169: [4/7] Added 'Master::authorize{Destroy,
Create}Volume' to create/destroy persistent volumes.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40169/
-----------------------------------------------------------
(Updated Dec. 17, 2015, 12:29 a.m.)
Review request for mesos, Jie Yu, Michael Park, and Neil Conway.
Changes
-------
Addressed comment.
Bugs: MESOS-4179
https://issues.apache.org/jira/browse/MESOS-4179
Repository: mesos
Description
-------
Added 'Master::authorize{Destroy,Create}Volume' to create/destroy persistent volumes.
Diffs (updated)
-----
src/master/master.hpp 9aa548aa6e159046c94e4ec96f631ea8b3bfd5d8
src/master/master.cpp 0d1482279c68f2a4a27dabaf28774769a5d515c4
Diff: https://reviews.apache.org/r/40169/diff/
Testing
-------
This is the fourth in a chain of 7 patches. `make check` was used to test after all patches were applied.
Thanks,
Greg Mann
Re: Review Request 40169: [4/7] Added 'Master::authorize{Destroy,
Create}Volume' to create/destroy persistent volumes.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40169/
-----------------------------------------------------------
(Updated Dec. 15, 2015, 9:18 p.m.)
Review request for mesos, Jie Yu, Michael Park, and Neil Conway.
Bugs: MESOS-4179
https://issues.apache.org/jira/browse/MESOS-4179
Repository: mesos
Description
-------
Added 'Master::authorize{Destroy,Create}Volume' to create/destroy persistent volumes.
Diffs
-----
src/master/master.hpp 4683fa542a740f9a0b80fff7fbe0e63ec66266f2
src/master/master.cpp 953fa4f14929581b226a7e27d30aea7a5aa1fd7c
Diff: https://reviews.apache.org/r/40169/diff/
Testing
-------
This is the fourth in a chain of 7 patches. `make check` was used to test after all patches were applied.
Thanks,
Greg Mann
Re: Review Request 40169: [4/7] Added 'Master::authorize{Destroy,
Create}Volume' to create/destroy persistent volumes.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40169/
-----------------------------------------------------------
(Updated Dec. 8, 2015, 6:44 p.m.)
Review request for mesos, Jie Yu, Michael Park, and Neil Conway.
Bugs: MESOS-3065
https://issues.apache.org/jira/browse/MESOS-3065
Repository: mesos
Description
-------
Added 'Master::authorize{Destroy,Create}Volume' to create/destroy persistent volumes.
Diffs (updated)
-----
src/master/master.hpp 4683fa542a740f9a0b80fff7fbe0e63ec66266f2
src/master/master.cpp 953fa4f14929581b226a7e27d30aea7a5aa1fd7c
Diff: https://reviews.apache.org/r/40169/diff/
Testing (updated)
-------
This is the fourth in a chain of 7 patches. `make check` was used to test after all patches were applied.
Thanks,
Greg Mann
Re: Review Request 40169: [4/7] Added 'Master::authorize{Destroy,
Create}Volume' to create/destroy persistent volumes.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40169/
-----------------------------------------------------------
(Updated Nov. 14, 2015, 12:18 a.m.)
Review request for mesos, Jie Yu, Michael Park, and Neil Conway.
Bugs: MESOS-3065
https://issues.apache.org/jira/browse/MESOS-3065
Repository: mesos
Description
-------
Added 'Master::authorize{Destroy,Create}Volume' to create/destroy persistent volumes.
Diffs (updated)
-----
src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2
src/master/master.cpp 7bac0fea4bcd040307fdfdcd002387d5baee46d1
Diff: https://reviews.apache.org/r/40169/diff/
Testing
-------
This is the fourth in a chain of 7 patches. `make check` was used to test after all patches were applied.
Note that this chain of patches touches many of the same files as another chain beginning with Review #39985 and ending with Review #39989, which is currently in review as well. To avoid conflicts, the beginning of this chain begins on top of Review #39989.
Thanks,
Greg Mann
Re: Review Request 40169: [4/7] Added 'Master::authorize{Destroy,
Create}Volume' to create/destroy persistent volumes.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40169/
-----------------------------------------------------------
(Updated Nov. 13, 2015, 6:30 p.m.)
Review request for mesos, Jie Yu, Michael Park, and Neil Conway.
Changes
-------
Addressed comment.
Bugs: MESOS-3065
https://issues.apache.org/jira/browse/MESOS-3065
Repository: mesos
Description
-------
Added 'Master::authorize{Destroy,Create}Volume' to create/destroy persistent volumes.
Diffs (updated)
-----
src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2
src/master/master.cpp 7bac0fea4bcd040307fdfdcd002387d5baee46d1
Diff: https://reviews.apache.org/r/40169/diff/
Testing
-------
This is the fourth in a chain of 7 patches. `make check` was used to test after all patches were applied.
Note that this chain of patches touches many of the same files as another chain beginning with Review #39985 and ending with Review #39989, which is currently in review as well. To avoid conflicts, the beginning of this chain begins on top of Review #39989.
Thanks,
Greg Mann
Re: Review Request 40169: [4/7] Added 'Master::authorize{Destroy,
Create}Volume' to create/destroy persistent volumes.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40169/
-----------------------------------------------------------
(Updated Nov. 13, 2015, 1:21 a.m.)
Review request for mesos, Jie Yu, Michael Park, and Neil Conway.
Bugs: MESOS-3065
https://issues.apache.org/jira/browse/MESOS-3065
Repository: mesos
Description
-------
Added 'Master::authorize{Destroy,Create}Volume' to create/destroy persistent volumes.
Diffs
-----
src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2
src/master/master.cpp 7bac0fea4bcd040307fdfdcd002387d5baee46d1
Diff: https://reviews.apache.org/r/40169/diff/
Testing (updated)
-------
This is the fourth in a chain of 7 patches. `make check` was used to test after all patches were applied.
Note that this chain of patches touches many of the same files as another chain beginning with Review #39985 and ending with Review #39989, which is currently in review as well. To avoid conflicts, the beginning of this chain begins on top of Review #39989.
Thanks,
Greg Mann