[GitHub] [ignite-3] AMashenkov commented on a change in pull request #150: Ignite-14785: Configuration API to SchemaBuilders

[GitBox <gi...@apache.org>]

AMashenkov commented on a change in pull request #150:
URL: https://github.com/apache/ignite-3/pull/150#discussion_r640512998



##########
File path: modules/table/src/test/java/org/apache/ignite/internal/table/StrictSchemaOperationsTest.java
##########
@@ -105,4 +108,25 @@ public void stringTypeMatch() {
         // Chek string 3 char length and 9 bytes.
         tbl.tupleBuilder().set("valString", "我是谁");
     }
+
+    /**
+     *
+     */
+    @Test
+    public void bytesTypeMatch() {
+        SchemaTable scmTbl = SchemaBuilders.tableBuilder("PUBLIC", "TBL").columns(
+            SchemaBuilders.column("key", ColumnType.INT8).asNonNull().build(),
+            SchemaBuilders.column("valUnlimited", ColumnType.blobOf()).asNullable().build(),
+            SchemaBuilders.column("valLimited", ColumnType.blobOf(2)).asNullable().build()
+        ).withPrimaryKey("key").build();
+
+        SchemaDescriptor schema = SchemaDescriptorConverter.convert(tableId, 1, scmTbl);
+
+        Table tbl = new TableImpl(new DummyInternalTableImpl(), new DummySchemaManagerImpl(schema));
+
+        tbl.tupleBuilder().set("valUnlimited", null);
+        tbl.tupleBuilder().set("valLimited", null);
+        tbl.tupleBuilder().set("valUnlimited", new byte[0]);
+        tbl.tupleBuilder().set("valLimited", new byte[0]);

Review comment:
           SchemaDescriptor schema = new SchemaDescriptor(
               tableId,
               1,
               new Column[] {new Column("id", NativeTypes.LONG, false)},
               new Column[] {
                   new Column("valUnlimited", NativeTypes.BYTES, true),
                   new Column("valLimited", NativeTypes.blobOf(2), true)
               }
           );
   
           Table tbl = new TableImpl(new DummyInternalTableImpl(), new DummySchemaManagerImpl(schema));
   
           tbl.tupleBuilder().set("valUnlimited", null);
           tbl.tupleBuilder().set("valLimited", null);
           tbl.tupleBuilder().set("valUnlimited", new byte[2]);
           tbl.tupleBuilder().set("valLimited", new byte[2]);
           tbl.tupleBuilder().set("valUnlimited", new byte[3]);
           assertThrows(InvalidTypeException.class, () -> tbl.tupleBuilder().set("valLimited", new byte[3]));
       }




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org