You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/10/07 13:55:10 UTC

[GitHub] [spark] srowen commented on a change in pull request #34163: [SPARK-36915][INFRA] Pin actions to a full length commit SHA

srowen commented on a change in pull request #34163:
URL: https://github.com/apache/spark/pull/34163#discussion_r724205021



##########
File path: .github/workflows/publish_snapshot.yml
##########
@@ -35,26 +35,26 @@ jobs:
           - branch-3.2
           - branch-3.1
     steps:
-    - name: Checkout Spark repository
-      uses: actions/checkout@master
-      with:
-        ref: ${{ matrix.branch }}
-    - name: Cache Maven local repository
-      uses: actions/cache@v2
-      with:
-        path: ~/.m2/repository
-        key: snapshot-maven-${{ hashFiles('**/pom.xml') }}
-        restore-keys: |
-          snapshot-maven-
-    - name: Install Java 8
-      uses: actions/setup-java@v1
-      with:
-        java-version: 8
-    - name: Publish snapshot
-      env:
-        ASF_USERNAME: ${{ secrets.NEXUS_USER }}
-        ASF_PASSWORD: ${{ secrets.NEXUS_PW }}
-        GPG_KEY: "not_used"
-        GPG_PASSPHRASE: "not_used"
-        GIT_REF: ${{ matrix.branch }}
-      run: ./dev/create-release/release-build.sh publish-snapshot
+      - name: Checkout Spark repository

Review comment:
       Is one or the other indentation more correct? would it cause merge conflicts to include these?
   Anyway if you don't feel strongly @naveensrinivasan could you revert these and we can get it in?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org