You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2023/01/17 08:52:28 UTC

[GitHub] [cloudstack] weizhouapache opened a new pull request, #7100: api/server: add project id/name in ssh keypair response

weizhouapache opened a new pull request, #7100:
URL: https://github.com/apache/cloudstack/pull/7100

   ### Description
   
   This fixes #7096
   
   <!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
   
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   
   <!--- ********************************************************************************* -->
   <!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
   <!--- PLEASE PUT AN 'X' in only **ONE** box -->
   <!--- ********************************************************************************* -->
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Feature/Enhancement Scale
   
   - [ ] Major
   - [ ] Minor
   
   #### Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [x] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to -->
   <!-- see how your change affects other areas of the code, etc. -->
   
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] rohityadavcloud commented on pull request #7100: api/server: add project id/name in ssh keypair response

Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #7100:
URL: https://github.com/apache/cloudstack/pull/7100#issuecomment-1386496452

   @blueorangutan package 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #7100: api/server: add project id/name in ssh keypair response

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #7100:
URL: https://github.com/apache/cloudstack/pull/7100#issuecomment-1386728497

   @blueorangutan test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #7100: api/server: add project id/name in ssh keypair response

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on code in PR #7100:
URL: https://github.com/apache/cloudstack/pull/7100#discussion_r1072300454


##########
api/src/main/java/org/apache/cloudstack/api/response/SSHKeyPairResponse.java:
##########
@@ -46,6 +46,14 @@ public class SSHKeyPairResponse extends BaseResponseWithAnnotations {
     @SerializedName(ApiConstants.DOMAIN) @Param(description="the domain name of the keypair owner")
     private String domain;
 
+    @SerializedName(ApiConstants.PROJECT_ID)
+    @Param(description = "the project id of the keypair owner")
+    private String projectId;
+
+    @SerializedName(ApiConstants.PROJECT)
+    @Param(description = "the project name of the keypair owner")
+    private String projectName;

Review Comment:
   same as other properties (zone id/name, domaini id/name, service offering id/name, etc) in other responses, the names are displayed on UI and more visible for users
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #7100: api/server: add project id/name in ssh keypair response

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7100:
URL: https://github.com/apache/cloudstack/pull/7100#issuecomment-1386496714

   @rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with  SystemVM template(s). I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] weizhouapache commented on pull request #7100: api/server: add project id/name in ssh keypair response

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on PR #7100:
URL: https://github.com/apache/cloudstack/pull/7100#issuecomment-1396712676

   > Tested, fixes the issue
   
   good thanks @davidjumani for testing


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #7100: api/server: add project id/name in ssh keypair response

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7100:
URL: https://github.com/apache/cloudstack/pull/7100#issuecomment-1387703939

   <b>Trillian test result (tid-5884)</b>
   Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
   Total time taken: 37410 seconds
   Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7100-t5884-kvm-centos7.zip
   Smoke tests completed. 101 look OK, 0 have errors, 0 did not run
   Only failed and skipped tests results shown below:
   
   
   Test | Result | Time (s) | Test File
   --- | --- | --- | ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #7100: api/server: add project id/name in ssh keypair response

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7100:
URL: https://github.com/apache/cloudstack/pull/7100#issuecomment-1386729485

   @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland merged pull request #7100: api/server: add project id/name in ssh keypair response

Posted by GitBox <gi...@apache.org>.
DaanHoogland merged PR #7100:
URL: https://github.com/apache/cloudstack/pull/7100


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] blueorangutan commented on pull request #7100: api/server: add project id/name in ssh keypair response

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #7100:
URL: https://github.com/apache/cloudstack/pull/7100#issuecomment-1386524782

   Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5299


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] weizhouapache closed pull request #7100: api/server: add project id/name in ssh keypair response

Posted by GitBox <gi...@apache.org>.
weizhouapache closed pull request #7100: api/server: add project id/name in ssh keypair response
URL: https://github.com/apache/cloudstack/pull/7100


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #7100: api/server: add project id/name in ssh keypair response

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on code in PR #7100:
URL: https://github.com/apache/cloudstack/pull/7100#discussion_r1072226672


##########
api/src/main/java/org/apache/cloudstack/api/response/SSHKeyPairResponse.java:
##########
@@ -46,6 +46,14 @@ public class SSHKeyPairResponse extends BaseResponseWithAnnotations {
     @SerializedName(ApiConstants.DOMAIN) @Param(description="the domain name of the keypair owner")
     private String domain;
 
+    @SerializedName(ApiConstants.PROJECT_ID)
+    @Param(description = "the project id of the keypair owner")
+    private String projectId;
+
+    @SerializedName(ApiConstants.PROJECT)
+    @Param(description = "the project name of the keypair owner")
+    private String projectName;

Review Comment:
   why do we need both in the response?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org