You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Sihua Zhou (JIRA)" <ji...@apache.org> on 2018/04/19 08:47:00 UTC
[jira] [Commented] (FLINK-9022) fix resource close in
`StreamTaskStateInitializerImpl.streamOperatorStateContext()`
[ https://issues.apache.org/jira/browse/FLINK-9022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16443752#comment-16443752 ]
Sihua Zhou commented on FLINK-9022:
-----------------------------------
[~srichter] Nice catch!
> fix resource close in `StreamTaskStateInitializerImpl.streamOperatorStateContext()`
> -----------------------------------------------------------------------------------
>
> Key: FLINK-9022
> URL: https://issues.apache.org/jira/browse/FLINK-9022
> Project: Flink
> Issue Type: Bug
> Components: State Backends, Checkpointing
> Affects Versions: 1.5.0
> Reporter: Sihua Zhou
> Assignee: Stefan Richter
> Priority: Blocker
> Fix For: 1.5.0
>
>
> We have the following code in {{StreamTaskStateInitializerImpl.streamOperatorStateContext()}} which is incorrect:
> {code}
> } catch (Exception ex) {
> // cleanup if something went wrong before results got published.
> if (streamTaskCloseableRegistry.unregisterCloseable(keyedStatedBackend)) {
> IOUtils.closeQuietly(keyedStatedBackend);
> }
> if (streamTaskCloseableRegistry.unregisterCloseable(operatorStateBackend)) {
> IOUtils.closeQuietly(keyedStatedBackend); // this should close operatorStateBackend
> }
> if (streamTaskCloseableRegistry.unregisterCloseable(rawKeyedStateInputs)) {
> IOUtils.closeQuietly(rawKeyedStateInputs);
> }
> if (streamTaskCloseableRegistry.unregisterCloseable(rawOperatorStateInputs)) {
> IOUtils.closeQuietly(rawOperatorStateInputs);
> }
> if (streamTaskCloseableRegistry.unregisterCloseable(rawOperatorStateInputs)) {
> IOUtils.closeQuietly(rawOperatorStateInputs);
> }
> throw new Exception("Exception while creating StreamOperatorStateContext.", ex);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)