You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anand Mazumdar <ma...@gmail.com> on 2015/11/10 06:46:34 UTC
Review Request 40125: Fixed quoted strings in executor log messages
on agent
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40125/
-----------------------------------------------------------
Review request for mesos, Joris Van Remoortere and Neil Conway.
Repository: mesos
Description
-------
As part of MESOS-3480, we introduced an output operator for the `Executor` struct on agent. It seems like the changes for MESOS-3772 got interpolated with that change later leading to erroneous quotes in executor log messages.
Diffs
-----
src/slave/slave.cpp 535adc3b17d5af3fe811a8e2505f126a28212dbf
Diff: https://reviews.apache.org/r/40125/diff/
Testing
-------
make check. I still wonder though how this escaped without merge conflicts when committing MESOS-3772.
Thanks,
Anand Mazumdar
Re: Review Request 40125: Fixed quoted strings in executor log
messages on agent
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40125/#review105797
-----------------------------------------------------------
Ship it!
Ship It!
- Joris Van Remoortere
On Nov. 10, 2015, 5:46 a.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40125/
> -----------------------------------------------------------
>
> (Updated Nov. 10, 2015, 5:46 a.m.)
>
>
> Review request for mesos, Joris Van Remoortere and Neil Conway.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> As part of MESOS-3480, we introduced an output operator for the `Executor` struct on agent. It seems like the changes for MESOS-3772 got interpolated with that change later leading to erroneous quotes in executor log messages.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp 535adc3b17d5af3fe811a8e2505f126a28212dbf
>
> Diff: https://reviews.apache.org/r/40125/diff/
>
>
> Testing
> -------
>
> make check. I still wonder though how this escaped without merge conflicts when committing MESOS-3772.
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 40125: Fixed quoted strings in executor log
messages on agent
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40125/#review105794
-----------------------------------------------------------
Bad patch!
Reviews applied: [40125]
Failed command: ./support/apply-review.sh -n -r 40125
Error:
2015-11-10 05:50:58 URL:https://reviews.apache.org/r/40125/diff/raw/ [7206/7206] -> "40125.patch" [1]
error: patch failed: src/slave/slave.cpp:1626
error: src/slave/slave.cpp: patch does not apply
Failed to apply patch
- Mesos ReviewBot
On Nov. 10, 2015, 5:46 a.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40125/
> -----------------------------------------------------------
>
> (Updated Nov. 10, 2015, 5:46 a.m.)
>
>
> Review request for mesos, Joris Van Remoortere and Neil Conway.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> As part of MESOS-3480, we introduced an output operator for the `Executor` struct on agent. It seems like the changes for MESOS-3772 got interpolated with that change later leading to erroneous quotes in executor log messages.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp 535adc3b17d5af3fe811a8e2505f126a28212dbf
>
> Diff: https://reviews.apache.org/r/40125/diff/
>
>
> Testing
> -------
>
> make check. I still wonder though how this escaped without merge conflicts when committing MESOS-3772.
>
>
> Thanks,
>
> Anand Mazumdar
>
>