You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "XComp (via GitHub)" <gi...@apache.org> on 2024/08/28 18:28:57 UTC

[PR] [FLINK-14068][streaming] Removes deprecated org.apache.flink.streaming.api.windowing.time.Time [flink]

XComp opened a new pull request, #25261:
URL: https://github.com/apache/flink/pull/25261

   ## What is the purpose of the change
   
   Removes deprecated `org.apache.flink.streaming.api.windowing.time.Time`
   
   ## Brief change log
   
   The changes where done using the IDE refactoring and find&replace operations.
   
   ## Verifying this change
   
   * CI should pass
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-14068][streaming] Removes deprecated org.apache.flink.streaming.api.windowing.time.Time [flink]

Posted by "zentol (via GitHub)" <gi...@apache.org>.
zentol commented on code in PR #25261:
URL: https://github.com/apache/flink/pull/25261#discussion_r1778600247


##########
README.md:
##########
@@ -41,7 +41,7 @@ val text = env.socketTextStream(host, port, '\n')
 val windowCounts = text.flatMap { w => w.split("\\s") }
   .map { w => WordWithCount(w, 1) }
   .keyBy("word")
-  .window(TumblingProcessingTimeWindow.of(Time.seconds(5)))

Review Comment:
   remove scala example?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-14068][streaming] Removes deprecated org.apache.flink.streaming.api.windowing.time.Time [flink]

Posted by "XComp (via GitHub)" <gi...@apache.org>.
XComp commented on code in PR #25261:
URL: https://github.com/apache/flink/pull/25261#discussion_r1778694960


##########
README.md:
##########
@@ -41,7 +41,7 @@ val text = env.socketTextStream(host, port, '\n')
 val windowCounts = text.flatMap { w => w.split("\\s") }
   .map { w => WordWithCount(w, 1) }
   .keyBy("word")
-  .window(TumblingProcessingTimeWindow.of(Time.seconds(5)))

Review Comment:
   I will leave that to [FLINK-36352](https://issues.apache.org/jira/browse/FLINK-36352)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-14068][streaming] Removes deprecated org.apache.flink.streaming.api.windowing.time.Time [flink]

Posted by "XComp (via GitHub)" <gi...@apache.org>.
XComp commented on PR #25261:
URL: https://github.com/apache/flink/pull/25261#issuecomment-2379099107

   Failure related to FLINK-36356.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-14068][streaming] Removes deprecated org.apache.flink.streaming.api.windowing.time.Time [flink]

Posted by "XComp (via GitHub)" <gi...@apache.org>.
XComp commented on code in PR #25261:
URL: https://github.com/apache/flink/pull/25261#discussion_r1736734100


##########
flink-streaming-scala/src/main/scala/org/apache/flink/streaming/api/scala/AllWindowedStream.scala:
##########
@@ -70,7 +71,7 @@ class AllWindowedStream[T, W <: Window](javaStream: JavaAllWStream[T, W]) {
    * thrown.
    */
   @PublicEvolving
-  def allowedLateness(lateness: Time): AllWindowedStream[T, W] = {
+  def allowedLateness(lateness: Duration): AllWindowedStream[T, W] = {

Review Comment:
   There are scala changes like that that didn't include proper deprecation because we wanted to remove scala entirely, anyway, in 2.0.
   
   What's the state with that?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-14068][streaming] Removes deprecated org.apache.flink.streaming.api.windowing.time.Time [flink]

Posted by "XComp (via GitHub)" <gi...@apache.org>.
XComp commented on PR #25261:
URL: https://github.com/apache/flink/pull/25261#issuecomment-2378600953

   Most of the Scala code is gone in `master` now which unblocked this PR (I had an issue with the Scala compiler fixing one of the windowAll comments and I didn't want to bother to fix it considering that we were planning to remove the Scala code). I rebased the branch and addressed all comments.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-14068][streaming] Removes deprecated org.apache.flink.streaming.api.windowing.time.Time [flink]

Posted by "XComp (via GitHub)" <gi...@apache.org>.
XComp commented on PR #25261:
URL: https://github.com/apache/flink/pull/25261#issuecomment-2379381101

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-14068][streaming] Removes deprecated org.apache.flink.streaming.api.windowing.time.Time [flink]

Posted by "XComp (via GitHub)" <gi...@apache.org>.
XComp commented on PR #25261:
URL: https://github.com/apache/flink/pull/25261#issuecomment-2380714808

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-14068][streaming] Removes deprecated org.apache.flink.streaming.api.windowing.time.Time [flink]

Posted by "zentol (via GitHub)" <gi...@apache.org>.
zentol commented on code in PR #25261:
URL: https://github.com/apache/flink/pull/25261#discussion_r1751623399


##########
flink-streaming-scala/src/test/scala/org/apache/flink/streaming/api/scala/TimeWindowTranslationTest.scala:
##########
@@ -68,13 +66,13 @@ class TimeWindowTranslationTest extends AbstractTestBaseJUnit4 {
 
     val window2 = source
       .keyBy(0)
-      .timeWindow(Time.minutes(1))
-      .apply(new WindowFunction[(String, Int), (String, Int), Tuple, TimeWindow]() {
-        def apply(
-            key: Tuple,
+      .windowAll(TumblingProcessingTimeWindows

Review Comment:
   same concern as elsewhere about windowAll on a keyed stream



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-14068][streaming] Removes deprecated org.apache.flink.streaming.api.windowing.time.Time [flink]

Posted by "XComp (via GitHub)" <gi...@apache.org>.
XComp commented on PR #25261:
URL: https://github.com/apache/flink/pull/25261#issuecomment-2379378432

   > Bit irritated that we still got scala examples in the docs, but it's not a problem for this PR I suppose.
   
   Looks like there is a separate issue FLINK-36352 for that.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-14068][streaming] Removes deprecated org.apache.flink.streaming.api.windowing.time.Time [flink]

Posted by "zentol (via GitHub)" <gi...@apache.org>.
zentol commented on code in PR #25261:
URL: https://github.com/apache/flink/pull/25261#discussion_r1751613908


##########
flink-runtime/src/test/java/org/apache/flink/streaming/runtime/operators/windowing/TimeWindowTranslationTest.java:
##########
@@ -79,22 +78,17 @@ void testAlignedWindowDeprecation() {
 
         DataStream<Tuple2<String, Integer>> window2 =
                 source.keyBy(0)
-                        .timeWindow(Time.of(1000, TimeUnit.MILLISECONDS))
+                        .windowAll(TumblingProcessingTimeWindows.of(Duration.ofMillis(1000)))

Review Comment:
   it's weird this uses an AllWindow when we have a keyed stream.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-14068][streaming] Removes deprecated org.apache.flink.streaming.api.windowing.time.Time [flink]

Posted by "zentol (via GitHub)" <gi...@apache.org>.
zentol commented on code in PR #25261:
URL: https://github.com/apache/flink/pull/25261#discussion_r1751604960


##########
docs/content.zh/docs/ops/state/task_failure_recovery.md:
##########
@@ -172,10 +172,10 @@ restart-strategy.exponential-delay.attempts-before-reset-backoff: 10
 ```java
 StreamExecutionEnvironment env = StreamExecutionEnvironment.getExecutionEnvironment();
 env.setRestartStrategy(RestartStrategies.exponentialDelayRestart(
-  Time.milliseconds(1),
-  Time.milliseconds(1000),
+  Duration.ofMillis(1),

Review Comment:
   I think this is wrong; this here uses the common Time class.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-14068][streaming] Removes deprecated org.apache.flink.streaming.api.windowing.time.Time [flink]

Posted by "zentol (via GitHub)" <gi...@apache.org>.
zentol commented on code in PR #25261:
URL: https://github.com/apache/flink/pull/25261#discussion_r1751619299


##########
flink-streaming-scala/src/main/scala/org/apache/flink/streaming/api/scala/CoGroupedStreams.scala:
##########
@@ -51,7 +52,7 @@ import scala.collection.JavaConverters._
  * val result = one.coGroup(two)
  *     .where(new MyFirstKeySelector())
  *     .equalTo(new MyFirstKeySelector())
- *     .window(TumblingEventTimeWindows.of(Time.of(5, TimeUnit.SECONDS)))
+ *     .window(TumblingEventTimeWindows.of(Time.ofSeconds(5)))

Review Comment:
   Duration.ofSeconds



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-14068][streaming] Removes deprecated org.apache.flink.streaming.api.windowing.time.Time [flink]

Posted by "XComp (via GitHub)" <gi...@apache.org>.
XComp commented on code in PR #25261:
URL: https://github.com/apache/flink/pull/25261#discussion_r1744113081


##########
flink-streaming-scala/src/main/scala/org/apache/flink/streaming/api/scala/AllWindowedStream.scala:
##########
@@ -70,7 +71,7 @@ class AllWindowedStream[T, W <: Window](javaStream: JavaAllWStream[T, W]) {
    * thrown.
    */
   @PublicEvolving
-  def allowedLateness(lateness: Time): AllWindowedStream[T, W] = {
+  def allowedLateness(lateness: Duration): AllWindowedStream[T, W] = {

Review Comment:
   I recovered the disabling of japicmp for Scala in FLINK-36207



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-14068][streaming] Removes deprecated org.apache.flink.streaming.api.windowing.time.Time [flink]

Posted by "zentol (via GitHub)" <gi...@apache.org>.
zentol commented on code in PR #25261:
URL: https://github.com/apache/flink/pull/25261#discussion_r1751617911


##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/TemporalTableFunctionJoinITCase.scala:
##########
@@ -21,20 +21,19 @@ import org.apache.flink.api.scala._
 import org.apache.flink.streaming.api.TimeCharacteristic
 import org.apache.flink.streaming.api.functions.timestamps.BoundedOutOfOrdernessTimestampExtractor
 import org.apache.flink.streaming.api.scala.StreamExecutionEnvironment
-import org.apache.flink.streaming.api.windowing.time.Time
 import org.apache.flink.table.api._
 import org.apache.flink.table.api.bridge.scala._
 import org.apache.flink.table.planner.runtime.utils.{StreamingWithStateTestBase, TestingAppendSink}
 import org.apache.flink.table.planner.runtime.utils.StreamingWithStateTestBase.StateBackendMode
 import org.apache.flink.table.planner.utils.TableTestUtil
 import org.apache.flink.testutils.junit.extensions.parameterized.ParameterizedTestExtension
-import org.apache.flink.types.Row

Review Comment:
   unrelated?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-14068][streaming] Removes deprecated org.apache.flink.streaming.api.windowing.time.Time [flink]

Posted by "XComp (via GitHub)" <gi...@apache.org>.
XComp commented on PR #25261:
URL: https://github.com/apache/flink/pull/25261#issuecomment-2379099992

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-14068][streaming] Removes deprecated org.apache.flink.streaming.api.windowing.time.Time [flink]

Posted by "XComp (via GitHub)" <gi...@apache.org>.
XComp commented on PR #25261:
URL: https://github.com/apache/flink/pull/25261#issuecomment-2316772519

   Converting this one to draft. Things to do:
   [ ] Going through the code diff and identifying wrong/missing code changes
   [ ] Going through the docs diff and identifying wrong/missing changes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-14068][streaming] Removes deprecated org.apache.flink.streaming.api.windowing.time.Time [flink]

Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #25261:
URL: https://github.com/apache/flink/pull/25261#issuecomment-2316011088

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e8fe75ea19d3de0a9ada8da66c38b2bd4343d0cd",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "e8fe75ea19d3de0a9ada8da66c38b2bd4343d0cd",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * e8fe75ea19d3de0a9ada8da66c38b2bd4343d0cd UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-14068][streaming] Removes deprecated org.apache.flink.streaming.api.windowing.time.Time [flink]

Posted by "zentol (via GitHub)" <gi...@apache.org>.
zentol commented on code in PR #25261:
URL: https://github.com/apache/flink/pull/25261#discussion_r1778604892


##########
docs/content.zh/docs/ops/state/task_failure_recovery.md:
##########
@@ -172,10 +172,10 @@ restart-strategy.exponential-delay.attempts-before-reset-backoff: 10
 ```java
 StreamExecutionEnvironment env = StreamExecutionEnvironment.getExecutionEnvironment();
 env.setRestartStrategy(RestartStrategies.exponentialDelayRestart(
-  Time.milliseconds(1),
-  Time.milliseconds(1000),
+  Duration.ofMillis(1),

Review Comment:
   This wasn't addressed yet?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-14068][streaming] Removes deprecated org.apache.flink.streaming.api.windowing.time.Time [flink]

Posted by "zentol (via GitHub)" <gi...@apache.org>.
zentol commented on code in PR #25261:
URL: https://github.com/apache/flink/pull/25261#discussion_r1751606292


##########
docs/content/docs/ops/state/task_failure_recovery.md:
##########
@@ -188,10 +188,10 @@ StreamExecutionEnvironment env = StreamExecutionEnvironment.getExecutionEnvironm
 ```scala
 val env = StreamExecutionEnvironment.getExecutionEnvironment()
 env.setRestartStrategy(RestartStrategies.exponentialDelayRestart(
-  Time.of(1, TimeUnit.MILLISECONDS), // initial delay between restarts
-  Time.of(1000, TimeUnit.MILLISECONDS), // maximum delay between restarts
+  Duration.ofMillis(1), // initial delay between restarts

Review Comment:
   I think this is wrong; this here uses the common Time class.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-14068][streaming] Removes deprecated org.apache.flink.streaming.api.windowing.time.Time [flink]

Posted by "reswqa (via GitHub)" <gi...@apache.org>.
reswqa commented on code in PR #25261:
URL: https://github.com/apache/flink/pull/25261#discussion_r1740293470


##########
flink-streaming-scala/src/main/scala/org/apache/flink/streaming/api/scala/AllWindowedStream.scala:
##########
@@ -70,7 +71,7 @@ class AllWindowedStream[T, W <: Window](javaStream: JavaAllWStream[T, W]) {
    * thrown.
    */
   @PublicEvolving
-  def allowedLateness(lateness: Time): AllWindowedStream[T, W] = {
+  def allowedLateness(lateness: Duration): AllWindowedStream[T, W] = {

Review Comment:
   I asked Martijn(looks like it was assigned to him in [2.0 Release Wiki](https://cwiki.apache.org/confluence/display/FLINK/2.0+Release)) on slack and haven't heard back yet.
   
   Can you reach out him to find out the state?
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-14068][streaming] Removes deprecated org.apache.flink.streaming.api.windowing.time.Time [flink]

Posted by "reswqa (via GitHub)" <gi...@apache.org>.
reswqa commented on code in PR #25261:
URL: https://github.com/apache/flink/pull/25261#discussion_r1740293470


##########
flink-streaming-scala/src/main/scala/org/apache/flink/streaming/api/scala/AllWindowedStream.scala:
##########
@@ -70,7 +71,7 @@ class AllWindowedStream[T, W <: Window](javaStream: JavaAllWStream[T, W]) {
    * thrown.
    */
   @PublicEvolving
-  def allowedLateness(lateness: Time): AllWindowedStream[T, W] = {
+  def allowedLateness(lateness: Duration): AllWindowedStream[T, W] = {

Review Comment:
   I asked Martijn(looks like it was assigned to him in [2.0 Release Wiki](https://cwiki.apache.org/confluence/display/FLINK/2.0+Release)) on slack and haven't heard back yet.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-14068][streaming] Removes deprecated org.apache.flink.streaming.api.windowing.time.Time [flink]

Posted by "XComp (via GitHub)" <gi...@apache.org>.
XComp commented on code in PR #25261:
URL: https://github.com/apache/flink/pull/25261#discussion_r1778695341


##########
docs/content.zh/docs/dev/datastream/operators/overview.md:
##########
@@ -198,19 +198,19 @@ data_stream.key_by(lambda x: x[1]).reduce(lambda a, b: (a[0] + b[0], b[1]))
 ```java
 dataStream
   .keyBy(value -> value.f0)
-  .window(TumblingEventTimeWindows.of(Time.seconds(5))); 
+  .window(TumblingEventTimeWindows.of(Duration.ofSeconds(5))); 
 ```
 {{< /tab >}}
 {{< tab "Scala">}}
 ```scala
 dataStream
   .keyBy(_._1)
-  .window(TumblingEventTimeWindows.of(Time.seconds(5))) 

Review Comment:
   FLINK-36352



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-14068][streaming] Removes deprecated org.apache.flink.streaming.api.windowing.time.Time [flink]

Posted by "zentol (via GitHub)" <gi...@apache.org>.
zentol commented on code in PR #25261:
URL: https://github.com/apache/flink/pull/25261#discussion_r1778601591


##########
docs/content.zh/docs/dev/datastream/operators/overview.md:
##########
@@ -198,19 +198,19 @@ data_stream.key_by(lambda x: x[1]).reduce(lambda a, b: (a[0] + b[0], b[1]))
 ```java
 dataStream
   .keyBy(value -> value.f0)
-  .window(TumblingEventTimeWindows.of(Time.seconds(5))); 
+  .window(TumblingEventTimeWindows.of(Duration.ofSeconds(5))); 
 ```
 {{< /tab >}}
 {{< tab "Scala">}}
 ```scala
 dataStream
   .keyBy(_._1)
-  .window(TumblingEventTimeWindows.of(Time.seconds(5))) 

Review Comment:
   why are the docs still full of scale examples if the apis were removed?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org