[GitHub] [beam] Malarg commented on a diff in pull request #26732: returned run shortcut, fixed pipeline options validation, added logs to ToB tests

["Malarg (via GitHub)" <gi...@apache.org>]

Malarg commented on code in PR #26732:
URL: https://github.com/apache/beam/pull/26732#discussion_r1196292443


##########
playground/frontend/playground_components/lib/src/controllers/example_loaders/examples_loader.dart:
##########
@@ -142,7 +144,18 @@ class ExamplesLoader {
   }
 
   Future<void> _loadOne(ExampleLoader loader) async {
-    final example = await loader.future;
+    Example example;
+    try {
+      example = await loader.future;

Review Comment:
   But that if something happened in `_playgroundController!.setExample`? In this case exception will be incorrect



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org