You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/09/02 21:19:20 UTC

[GitHub] [superset] hughhhh commented on a diff in pull request #21245: feat: Update nav bar with new data information architecture for SQL Lab + SQL

hughhhh commented on code in PR #21245:
URL: https://github.com/apache/superset/pull/21245#discussion_r962020683


##########
superset/initialization/__init__.py:
##########
@@ -328,18 +348,19 @@ def init_views(self) -> None:
         )
         appbuilder.add_link(
             "SQL Editor",
-            label=_("SQL Editor"),
+            label=_("SQL Lab"),
             href="/superset/sqllab/",
             category_icon="fa-flask",
             icon="fa-flask",
             category="SQL Lab",
-            category_label=__("SQL Lab"),
+            category_label=__("SQL"),

Review Comment:
   it's using the can_sqllab permission



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org