You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tika.apache.org by ju...@apache.org on 2010/10/10 21:20:26 UTC
svn commit: r1006342 -
/tika/trunk/tika-core/src/test/java/org/apache/tika/mime/MimeTypesReaderTest.java
Author: jukka
Date: Sun Oct 10 19:20:26 2010
New Revision: 1006342
URL: http://svn.apache.org/viewvc?rev=1006342&view=rev
Log:
Remove extra System.out prints from a test case, clean whitespace
Modified:
tika/trunk/tika-core/src/test/java/org/apache/tika/mime/MimeTypesReaderTest.java
Modified: tika/trunk/tika-core/src/test/java/org/apache/tika/mime/MimeTypesReaderTest.java
URL: http://svn.apache.org/viewvc/tika/trunk/tika-core/src/test/java/org/apache/tika/mime/MimeTypesReaderTest.java?rev=1006342&r1=1006341&r2=1006342&view=diff
==============================================================================
--- tika/trunk/tika-core/src/test/java/org/apache/tika/mime/MimeTypesReaderTest.java (original)
+++ tika/trunk/tika-core/src/test/java/org/apache/tika/mime/MimeTypesReaderTest.java Sun Oct 10 19:20:26 2010
@@ -16,9 +16,6 @@
*/
package org.apache.tika.mime;
-import java.io.ByteArrayInputStream;
-import java.io.IOException;
-import java.io.InputStream;
import java.lang.reflect.Field;
import java.util.ArrayList;
import java.util.List;
@@ -27,7 +24,6 @@ import java.util.SortedSet;
import junit.framework.TestCase;
import org.apache.tika.config.TikaConfig;
-import org.apache.tika.metadata.Metadata;
/**
* These tests try to ensure that the MimeTypesReader
@@ -53,19 +49,19 @@ public class MimeTypesReaderTest extends
protected void setUp() throws Exception {
super.setUp();
this.mimeTypes = TikaConfig.getDefaultConfig().getMimeRepository();
-
+
Field magicsField = mimeTypes.getClass().getDeclaredField("magics");
magicsField.setAccessible(true);
magics = (SortedSet<Magic>)magicsField.get(mimeTypes);
-
+
Field xmlsField = mimeTypes.getClass().getDeclaredField("xmls");
xmlsField.setAccessible(true);
xmls = (SortedSet<MimeType>)xmlsField.get(mimeTypes);
}
-
+
public void testHtmlMatches() throws Exception {
int minMatches = 10;
-
+
// Check on the type
MimeType html = mimeTypes.forName("text/html");
assertTrue(html.hasMagic());
@@ -73,8 +69,7 @@ public class MimeTypesReaderTest extends
"There should be at least "+minMatches+" HTML matches, found " + html.getMagics().length,
html.getMagics().length >= minMatches
);
-
-
+
// Check on the overall magics
List<Magic> htmlMagics = new ArrayList<Magic>();
for(Magic magic : magics) {
@@ -82,16 +77,16 @@ public class MimeTypesReaderTest extends
htmlMagics.add(magic);
}
}
-
+
assertTrue(
"There should be at least "+minMatches+" HTML matches, found " + htmlMagics.size(),
htmlMagics.size() >= minMatches
);
}
-
+
public void testExcelMatches() throws Exception {
int minMatches = 4;
-
+
// Check on the type
MimeType excel = mimeTypes.forName("application/vnd.ms-excel");
assertTrue(excel.hasMagic());
@@ -99,20 +94,19 @@ public class MimeTypesReaderTest extends
"There should be at least "+minMatches+" Excel matches, found " + excel.getMagics().length,
excel.getMagics().length >= minMatches
);
-
-
+
// Check on the overall magics
List<Magic> excelMagics = new ArrayList<Magic>();
for(Magic magic : magics) {
if(magic.getType().toString().equals("application/vnd.ms-excel")) {
excelMagics.add(magic);
- System.out.println(magic);
}
}
-
+
assertTrue(
"There should be at least "+minMatches+" Excel matches, found " + excelMagics.size(),
excelMagics.size() >= minMatches
);
}
+
}