[GitHub] sijie commented on a change in pull request #1125: Issue #1124: Lower memory usage in GarbageCollectionThread while extracting all ledger meta data

[GitBox <gi...@apache.org>]

sijie commented on a change in pull request #1125: Issue #1124: Lower memory usage in GarbageCollectionThread while extracting all ledger meta data
URL: https://github.com/apache/bookkeeper/pull/1125#discussion_r166613240
 
 

 ##########
 File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/CompactionTest.java
 ##########
 @@ -835,6 +837,70 @@ public void checkpointComplete(Checkpoint checkpoint,
         storage.gcThread.doCompactEntryLogs(threshold);
     }
 
+    /**
+     * Test extractMetaFromEntryLogs optimized method to avoid excess memory usage.
+     */
+    @Test(timeout = 60000)
+    public void testExtractMetaFromEntryLogs() throws Exception {
+        tearDown(); // I dont want the test infrastructure
 
 Review comment:
   If you don't want the test infra in this test suite, is it better to just have this as a separate test case?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services