You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Xi Wang <xw...@hortonworks.com> on 2016/12/30 02:15:42 UTC

Review Request 55095: Improve and Fix "Admin page" after new guidelines

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55095/
-----------------------------------------------------------

Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel Subramanian, and Yusaku Sako.


Bugs: AMBARI-19322
    https://issues.apache.org/jira/browse/AMBARI-19322


Repository: ambari


Description
-------

1. Admin > Versions: lines broke.
2. Version details: Hosts line height should be larger.


Diffs
-----

  ambari-web/app/styles/stack_versions.less 6698dfa 
  ambari-web/app/templates/main/admin/stack_upgrade/upgrade_version_column.hbs 7cd9ffb 
  ambari-web/app/templates/main/admin/stack_upgrade/versions.hbs a82aad6 
  ambari-web/app/views/main/admin/stack_upgrade/upgrade_version_column_view.js 15d9701 

Diff: https://reviews.apache.org/r/55095/diff/


Testing
-------

19838 passing (20s)
153 pending


Thanks,

Xi Wang


Re: Review Request 55095: Improve and Fix "Admin page" after new guidelines

Posted by Vivek Ratnavel Subramanian <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55095/#review160290
-----------------------------------------------------------


Ship it!




Ship It!

- Vivek Ratnavel Subramanian


On Dec. 30, 2016, 2:15 a.m., Xi Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55095/
> -----------------------------------------------------------
> 
> (Updated Dec. 30, 2016, 2:15 a.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel Subramanian, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-19322
>     https://issues.apache.org/jira/browse/AMBARI-19322
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> 1. Admin > Versions: lines broke.
> 2. Version details: Hosts line height should be larger.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/styles/stack_versions.less 6698dfa 
>   ambari-web/app/templates/main/admin/stack_upgrade/upgrade_version_column.hbs 7cd9ffb 
>   ambari-web/app/templates/main/admin/stack_upgrade/versions.hbs a82aad6 
>   ambari-web/app/views/main/admin/stack_upgrade/upgrade_version_column_view.js 15d9701 
> 
> Diff: https://reviews.apache.org/r/55095/diff/
> 
> 
> Testing
> -------
> 
> 19838 passing (20s)
> 153 pending
> 
> 
> Thanks,
> 
> Xi Wang
> 
>