You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/04/12 09:35:31 UTC

[GitHub] [airflow] alexInhert opened a new issue #15326: KubernetesPodOperator unclear error message when name is missing

alexInhert opened a new issue #15326:
URL: https://github.com/apache/airflow/issues/15326


   in KubernetesPodOperator the name parameter is mandatory.
   However if you forget to add it you will get a broken dag message with:
   ![Screen Shot 2021-04-12 at 12 16 58](https://user-images.githubusercontent.com/62940116/114373136-f699d180-9b8a-11eb-8500-d8e7118650ae.png)
   
   This is because
   https://github.com/apache/airflow/blob/1dfbb8d2031cb8a3e95e4bf91aa478857c5c3a85/airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py#L277
   
   it calls validate_data which produce this error:
   https://github.com/apache/airflow/blob/1dfbb8d2031cb8a3e95e4bf91aa478857c5c3a85/airflow/utils/helpers.py#L40
   
   The error is not useful. It doesn't explain what the issue is of where the problem is. it also says problem with `key` which isn't a parameter of anything.
   I couldn't even know that the issue is from the KubernetesPodOperator.
   
   Suggestions:
   make better error message for `KubernetesPodOperator` when name parameter is missing OR invalid.
   
   I would also suggest to make validate_key produce a better error message specifying what object produce the error


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] kaxil closed issue #15326: KubernetesPodOperator unclear error message when name is missing

Posted by GitBox <gi...@apache.org>.
kaxil closed issue #15326:
URL: https://github.com/apache/airflow/issues/15326


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] jedcunningham commented on issue #15326: KubernetesPodOperator unclear error message when name is missing

Posted by GitBox <gi...@apache.org>.
jedcunningham commented on issue #15326:
URL: https://github.com/apache/airflow/issues/15326#issuecomment-819703556


   The behavior with the latest provider is arguably worse, as it will run with a pod named `name` with no extra randomization. The linked PR will raise an exception with a useful message in the case where someone forgets the name.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org