You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/06/11 12:53:54 UTC
[GitHub] [airflow] potiuk opened a new pull request, #24389: Add tool to fix missing "source" links in our documentation
potiuk opened a new pull request, #24389:
URL: https://github.com/apache/airflow/pull/24389
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragement file, named `{pr_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #24389: Add tool to fix missing "source" links in our documentation
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #24389:
URL: https://github.com/apache/airflow/pull/24389#issuecomment-1154493417
The tool is optimized now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #24389: Add tool to fix missing "source" links in our documentation
Posted by GitBox <gi...@apache.org>.
ashb commented on PR #24389:
URL: https://github.com/apache/airflow/pull/24389#issuecomment-1153672617
Do we need this in the repo? Once we've run it we don't need it anymore do we?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed pull request #24389: Add tool to fix missing "source" links in our documentation
Posted by GitBox <gi...@apache.org>.
potiuk closed pull request #24389: Add tool to fix missing "source" links in our documentation
URL: https://github.com/apache/airflow/pull/24389
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #24389: Add tool to fix missing "source" links in our documentation
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #24389:
URL: https://github.com/apache/airflow/pull/24389#issuecomment-1153732520
Also those are useful in case somoen finds a problem with such mass-updated changes like you did https://github.com/apache/airflow-site/pull/613#discussion_r895503440 @ashb - (I will look into that).
If we've already merged the change and if there is a mistake that would lead to wrong corrections of the link, the easiest way to find why and fix it is to have reference to the script that was used. Otherwise any diagnosis and fix by anyone else but me hoping to still keep the script around would be much more difficult.
So say this is a way to not loose time with any followups.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #24389: Add tool to fix missing "source" links in our documentation
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #24389:
URL: https://github.com/apache/airflow/pull/24389#issuecomment-1181187117
I would love to get it in (just for tracking of what has been done).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #24389: Add tool to fix missing "source" links in our documentation
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #24389:
URL: https://github.com/apache/airflow/pull/24389#issuecomment-1161464676
@ashb ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #24389: Add tool to fix missing "source" links in our documentation
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #24389:
URL: https://github.com/apache/airflow/pull/24389#issuecomment-1153708653
> Do we need this in the repo? Once we've run it we don't need it anymore do we?
It's good for reference to find it. Also @josh-fell used them later as a reference and good "source" of what has been fixed in building astronomer index. I find it useful to keep it there, in case someone wants to have similar fix in the future. First time it took me quite some time to figure out how to do, second time it was couple of minutes precisely because I could find it easily how it was done before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #24389: Add tool to fix missing "source" links in our documentation
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #24389:
URL: https://github.com/apache/airflow/pull/24389#issuecomment-1192948928
Would love to merge this one - we have one more case that might need fixes and it would be great to get this one as a base.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #24389: Add tool to fix missing "source" links in our documentation
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #24389:
URL: https://github.com/apache/airflow/pull/24389#issuecomment-1154949427
Applied the latest fix @ashb .
I'd very much like to keep those scripts in, actually (as explained - there might be errors we missed during the review, the https://github.com/apache/airflow-site/pull/613 has reference to this PR and scripts used to fix the problems so we have an easy way to revert and re-run the fixes in case we find out that we need to. The interlinking in PRs make it permanent trace to all such changes for anyone who might want to wonder where it came from (and might even fix it if I am not around).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org