You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by DontPanicBaby <gi...@git.apache.org> on 2016/07/01 13:00:40 UTC

[GitHub] thrift pull request #1038: replace 'binary' on the base types

GitHub user DontPanicBaby opened a pull request:

    https://github.com/apache/thrift/pull/1038

    replace 'binary' on the base types

    json generator creates file with "binary" type instead thrift base types. As a result, it is impossible to identify the type.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/DontPanicBaby/thrift master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/1038.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1038
    
----
commit 607da959a0ebcac1953a70694d36d8e180c7c0cd
Author: roman.suchkov <ro...@exness.com>
Date:   2016-07-01T12:52:13Z

    replace 'binary' on the base types

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift issue #1038: replace 'binary' on the base types

Posted by jeking3 <gi...@git.apache.org>.

Github user jeking3 commented on the issue:

    https://github.com/apache/thrift/pull/1038
  
    This needs a Jira item opened for it, and needs to be rebased and merge conflicts fixed.
    See; https://thrift.apache.org/docs/HowToContribute
    Thanks.


---

[GitHub] thrift issue #1038: replace 'binary' on the base types

Posted by DontPanicBaby <gi...@git.apache.org>.

Github user DontPanicBaby commented on the issue:

    https://github.com/apache/thrift/pull/1038
  
    I need to know exactly type of variable. The current implementation does not allow it. I write serializer based on json generator's result and i can't serialize binary, becose i don't know how many bytes needs for variable. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift issue #1038: replace 'binary' on the base types

Posted by Jens-G <gi...@git.apache.org>.

Github user Jens-G commented on the issue:

    https://github.com/apache/thrift/pull/1038
  
    But ```binary```is a basis type?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift issue #1038: replace 'binary' on the base types

Posted by jeking3 <gi...@git.apache.org>.

Github user jeking3 commented on the issue:

    https://github.com/apache/thrift/pull/1038
  
    This needs a Jira item opened for it, and needs to be rebased and merge conflicts fixed.
    See; https://thrift.apache.org/docs/HowToContribute
    Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---