You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/10/17 15:24:19 UTC
[GitHub] [maven-release] slachiewicz commented on a change in pull request #56: [MRELEASE-1042] releaseProfiles get overriden by activeProfiles
slachiewicz commented on a change in pull request #56:
URL: https://github.com/apache/maven-release/pull/56#discussion_r506953558
##########
File path: maven-release-manager/src/main/java/org/apache/maven/shared/release/DefaultReleaseManager.java
##########
@@ -304,21 +305,26 @@ private void perform( ReleasePerformRequest performRequest, ReleaseResult result
ReleaseUtils.buildReleaseDescriptor( performRequest.getReleaseDescriptorBuilder() )
.getActivateProfiles();
- ReleaseDescriptor releaseDescriptor =
- loadReleaseDescriptor( performRequest.getReleaseDescriptorBuilder(),
- performRequest.getReleaseManagerListener() );
+ ReleaseDescriptorBuilder builder =
+ loadReleaseDescriptorBuilder( performRequest.getReleaseDescriptorBuilder(),
+ performRequest.getReleaseManagerListener() );
if ( specificProfiles != null && !specificProfiles.isEmpty() )
{
+ List<String> allProfiles = new ArrayList<>();
Review comment:
Here we inject an immutable list - so the test case is in fact wrong.
https://github.com/apache/maven-release/blob/master/maven-release-manager/src/main/java/org/apache/maven/shared/release/config/ReleaseUtils.java#L130-L134
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org