You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/07/29 17:37:46 UTC
[GitHub] [incubator-nuttx-apps] johannes-nivus opened a new pull request #349: Testing for UTF8 support for FAT Filesystem.
johannes-nivus opened a new pull request #349:
URL: https://github.com/apache/incubator-nuttx-apps/pull/349
## Summary
Testing for CONFIG_FAT_LFN_UTF8, because nsh doesn't accept characters outside 0x7f
## Impact
--
## Testing
--
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #349: Testing for UTF8 support for FAT Filesystem.
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #349:
URL: https://github.com/apache/incubator-nuttx-apps/pull/349#discussion_r462440150
##########
File path: testing/fatutf8/Makefile
##########
@@ -0,0 +1,49 @@
+############################################################################
+# apps/testing/fatutf8/Makefile
+#
+# Copyright (C) 2019 Gregory Nutt. All rights reserved.
Review comment:
@johannes-nivus Need change to Apache license.
##########
File path: testing/fatutf8/Make.defs
##########
@@ -0,0 +1,39 @@
+############################################################################
+# apps/testing/fatutf8/Make.defs
+# Adds selected applications to apps/ build
+#
+# Copyright (C) 2019 Gregory Nutt. All rights reserved.
Review comment:
@johannes-nivus Need change to Apache license.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] acassis merged pull request #349: Testing for UTF8 support for FAT Filesystem.
Posted by GitBox <gi...@apache.org>.
acassis merged pull request #349:
URL: https://github.com/apache/incubator-nuttx-apps/pull/349
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] acassis commented on pull request #349: Testing for UTF8 support for FAT Filesystem.
Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #349:
URL: https://github.com/apache/incubator-nuttx-apps/pull/349#issuecomment-667355382
Since all issues were fixed, I will merge it!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org