You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Mickael Istria <mi...@redhat.com> on 2018/12/06 09:41:58 UTC
MNG-6533 and MNG-6529
Hi all,
As part of a major performance improvement in m2e, we'd like to use the
ProjectBuilder.build(list_of_poms, ...) which drastically reduce CPU and
RAM consumption compared to iterating on ProjectBuilder.build(single_pom,
...).
We identified 2 relatively small limitations blocking m2e from adoption
ProjectBuilder.build(list_of_poms,...) that seems to just be missing
features compared to ProjectBuilder.build(single_pom...) because no-one
needed them to so far. We're covered these 2 issues in MNG-6529 and
MNG-6533; and there are pull requests open for both.
We'd appreciate if those can be targeted for review (and if everything is
fine, merge) as part of next release.
Thanks in advance.
--
Mickael Istria
Eclipse IDE <https://www.eclipse.org/downloads/eclipse-packages/>
developer, for Red Hat Developers <https://developers.redhat.com/>
Re: MNG-6533 and MNG-6529
Posted by Mickael Istria <mi...@redhat.com>.
Hi,
On Sun, Dec 9, 2018 at 7:37 PM Enrico Olivelli <eo...@gmail.com> wrote:
> IMHO maybe you can ask the contributor to add the 'allow edits from
> maintainers' or you can import the commit into another branch
As the contributor here, here is how I think things would work best for me
and the project, short and long term: committers/reviewers just ask on the
PR what they they'd like the author to change in the PR, explaining why
they think it's necessary (ideally referencing some "how to contribute"
documentation where the workflow is documented). So I learn the practices
of the project and will be more productive next time, and I ship a "more
complete" work by myself without requiring committers to provide
extra-patches.
Cheers,
--
Mickael Istria
Eclipse IDE <https://www.eclipse.org/downloads/eclipse-packages/>
developer, for Red Hat Developers <https://developers.redhat.com/>
Re: MNG-6533 and MNG-6529
Posted by Enrico Olivelli <eo...@gmail.com>.
Il dom 9 dic 2018, 19:35 Robert Scholte <rf...@apache.org> ha scritto:
> On Sun, 09 Dec 2018 18:48:19 +0100, Hervé BOUTEMY <he...@free.fr>
>
> wrote:
>
> > +1 for MNG-6529
> > we'll just have to see how we merge changes done in the Maven branch with
> > updates to the PR...
>
> Right, looks like I cannot update the MNG-6529 branch with the PR.
> So what to do now?
>
IMHO maybe you can ask the contributor to add the 'allow edits from
maintainers' or you can import the commit into another branch
Enrico
> Robert
>
> >
> > for MNG-6533, I'm less clear: what is in the Maven branch does not
> > correspond
> > to the PR
> > what should we really check?
> >
> > Regards,
> >
> > Hervé
> >
> > Le dimanche 9 décembre 2018, 16:24:22 CET Robert Scholte a écrit :
> >>
> https://builds.apache.org/view/M-R/view/Maven/job/maven-box/job/maven/job/MN
> >> G-6533/
> >>
> https://builds.apache.org/view/M-R/view/Maven/job/maven-box/job/maven/job/M
> >> NG-6529/
> >>
> >> Both look fine.
> >> If another Maven team member can second these PRs I will merge them to
> >> master.
> >>
> >> thanks,
> >> Robert
> >>
> >> On Sat, 08 Dec 2018 11:16:26 +0100, Robert Scholte
> >> <rf...@apache.org>
> >>
> >> wrote:
> >> > These PRs look fine, I'll run them on our CI servers.
> >> >
> >> > thanks,
> >> > Robert
> >> >
> >> > On Thu, 06 Dec 2018 10:41:58 +0100, Mickael Istria
> >> <mi...@redhat.com>
> >> >
> >> > wrote:
> >> >> Hi all,
> >> >>
> >> >> As part of a major performance improvement in m2e, we'd like to use
> >> the
> >> >> ProjectBuilder.build(list_of_poms, ...) which drastically reduce
> CPU
> >> and
> >> >> RAM consumption compared to iterating on
> >> >> ProjectBuilder.build(single_pom,
> >> >> ...).
> >> >> We identified 2 relatively small limitations blocking m2e from
> >> adoption
> >> >> ProjectBuilder.build(list_of_poms,...) that seems to just be missing
> >> >> features compared to ProjectBuilder.build(single_pom...) because
> >> no-one
> >> >> needed them to so far. We're covered these 2 issues in MNG-6529 and
> >> >> MNG-6533; and there are pull requests open for both.
> >> >> We'd appreciate if those can be targeted for review (and if
> >> everything
> >> >> is
> >> >> fine, merge) as part of next release.
> >> >>
> >> >> Thanks in advance.
> >> >
> >> > ---------------------------------------------------------------------
> >> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> >> > For additional commands, e-mail: dev-help@maven.apache.org
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> >> For additional commands, e-mail: dev-help@maven.apache.org
> >
> >
> >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > For additional commands, e-mail: dev-help@maven.apache.org
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
> --
-- Enrico Olivelli
Re: MNG-6533 and MNG-6529
Posted by Robert Scholte <rf...@apache.org>.
On Sun, 09 Dec 2018 18:48:19 +0100, Hervé BOUTEMY <he...@free.fr>
wrote:
> +1 for MNG-6529
> we'll just have to see how we merge changes done in the Maven branch with
> updates to the PR...
Right, looks like I cannot update the MNG-6529 branch with the PR.
So what to do now?
Robert
>
> for MNG-6533, I'm less clear: what is in the Maven branch does not
> correspond
> to the PR
> what should we really check?
>
> Regards,
>
> Hervé
>
> Le dimanche 9 décembre 2018, 16:24:22 CET Robert Scholte a écrit :
>> https://builds.apache.org/view/M-R/view/Maven/job/maven-box/job/maven/job/MN
>> G-6533/
>> https://builds.apache.org/view/M-R/view/Maven/job/maven-box/job/maven/job/M
>> NG-6529/
>>
>> Both look fine.
>> If another Maven team member can second these PRs I will merge them to
>> master.
>>
>> thanks,
>> Robert
>>
>> On Sat, 08 Dec 2018 11:16:26 +0100, Robert Scholte
>> <rf...@apache.org>
>>
>> wrote:
>> > These PRs look fine, I'll run them on our CI servers.
>> >
>> > thanks,
>> > Robert
>> >
>> > On Thu, 06 Dec 2018 10:41:58 +0100, Mickael Istria
>> <mi...@redhat.com>
>> >
>> > wrote:
>> >> Hi all,
>> >>
>> >> As part of a major performance improvement in m2e, we'd like to use
>> the
>> >> ProjectBuilder.build(list_of_poms, ...) which drastically reduce CPU
>> and
>> >> RAM consumption compared to iterating on
>> >> ProjectBuilder.build(single_pom,
>> >> ...).
>> >> We identified 2 relatively small limitations blocking m2e from
>> adoption
>> >> ProjectBuilder.build(list_of_poms,...) that seems to just be missing
>> >> features compared to ProjectBuilder.build(single_pom...) because
>> no-one
>> >> needed them to so far. We're covered these 2 issues in MNG-6529 and
>> >> MNG-6533; and there are pull requests open for both.
>> >> We'd appreciate if those can be targeted for review (and if
>> everything
>> >> is
>> >> fine, merge) as part of next release.
>> >>
>> >> Thanks in advance.
>> >
>> > ---------------------------------------------------------------------
>> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> > For additional commands, e-mail: dev-help@maven.apache.org
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: MNG-6533 and MNG-6529
Posted by Hervé BOUTEMY <he...@free.fr>.
+1 for MNG-6529
we'll just have to see how we merge changes done in the Maven branch with
updates to the PR...
for MNG-6533, I'm less clear: what is in the Maven branch does not correspond
to the PR
what should we really check?
Regards,
Hervé
Le dimanche 9 décembre 2018, 16:24:22 CET Robert Scholte a écrit :
> https://builds.apache.org/view/M-R/view/Maven/job/maven-box/job/maven/job/MN
> G-6533/
> https://builds.apache.org/view/M-R/view/Maven/job/maven-box/job/maven/job/M
> NG-6529/
>
> Both look fine.
> If another Maven team member can second these PRs I will merge them to
> master.
>
> thanks,
> Robert
>
> On Sat, 08 Dec 2018 11:16:26 +0100, Robert Scholte <rf...@apache.org>
>
> wrote:
> > These PRs look fine, I'll run them on our CI servers.
> >
> > thanks,
> > Robert
> >
> > On Thu, 06 Dec 2018 10:41:58 +0100, Mickael Istria <mi...@redhat.com>
> >
> > wrote:
> >> Hi all,
> >>
> >> As part of a major performance improvement in m2e, we'd like to use the
> >> ProjectBuilder.build(list_of_poms, ...) which drastically reduce CPU and
> >> RAM consumption compared to iterating on
> >> ProjectBuilder.build(single_pom,
> >> ...).
> >> We identified 2 relatively small limitations blocking m2e from adoption
> >> ProjectBuilder.build(list_of_poms,...) that seems to just be missing
> >> features compared to ProjectBuilder.build(single_pom...) because no-one
> >> needed them to so far. We're covered these 2 issues in MNG-6529 and
> >> MNG-6533; and there are pull requests open for both.
> >> We'd appreciate if those can be targeted for review (and if everything
> >> is
> >> fine, merge) as part of next release.
> >>
> >> Thanks in advance.
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > For additional commands, e-mail: dev-help@maven.apache.org
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: MNG-6533 and MNG-6529
Posted by Enrico Olivelli <eo...@gmail.com>.
Il dom 9 dic 2018, 16:24 Robert Scholte <rf...@apache.org> ha scritto:
>
> https://builds.apache.org/view/M-R/view/Maven/job/maven-box/job/maven/job/MNG-6533/
>
> https://builds.apache.org/view/M-R/view/Maven/job/maven-box/job/maven/job/MNG-6529/
>
> Both look fine.
> If another Maven team member can second these PRs I will merge them to
> master.
>
I left some comment on 6529 about adding a test case.
Regarding 6533 I don't have enough experience to say it is good
Enrico
>
> thanks,
> Robert
>
> On Sat, 08 Dec 2018 11:16:26 +0100, Robert Scholte <rf...@apache.org>
>
> wrote:
>
> > These PRs look fine, I'll run them on our CI servers.
> >
> > thanks,
> > Robert
> >
> > On Thu, 06 Dec 2018 10:41:58 +0100, Mickael Istria <mi...@redhat.com>
>
> > wrote:
> >
> >> Hi all,
> >>
> >> As part of a major performance improvement in m2e, we'd like to use the
> >> ProjectBuilder.build(list_of_poms, ...) which drastically reduce CPU and
> >> RAM consumption compared to iterating on
> >> ProjectBuilder.build(single_pom,
> >> ...).
> >> We identified 2 relatively small limitations blocking m2e from adoption
> >> ProjectBuilder.build(list_of_poms,...) that seems to just be missing
> >> features compared to ProjectBuilder.build(single_pom...) because no-one
> >> needed them to so far. We're covered these 2 issues in MNG-6529 and
> >> MNG-6533; and there are pull requests open for both.
> >> We'd appreciate if those can be targeted for review (and if everything
> >> is
> >> fine, merge) as part of next release.
> >>
> >> Thanks in advance.
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > For additional commands, e-mail: dev-help@maven.apache.org
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
> --
-- Enrico Olivelli
Re: MNG-6533 and MNG-6529
Posted by Robert Scholte <rf...@apache.org>.
https://builds.apache.org/view/M-R/view/Maven/job/maven-box/job/maven/job/MNG-6533/
https://builds.apache.org/view/M-R/view/Maven/job/maven-box/job/maven/job/MNG-6529/
Both look fine.
If another Maven team member can second these PRs I will merge them to
master.
thanks,
Robert
On Sat, 08 Dec 2018 11:16:26 +0100, Robert Scholte <rf...@apache.org>
wrote:
> These PRs look fine, I'll run them on our CI servers.
>
> thanks,
> Robert
>
> On Thu, 06 Dec 2018 10:41:58 +0100, Mickael Istria <mi...@redhat.com>
> wrote:
>
>> Hi all,
>>
>> As part of a major performance improvement in m2e, we'd like to use the
>> ProjectBuilder.build(list_of_poms, ...) which drastically reduce CPU and
>> RAM consumption compared to iterating on
>> ProjectBuilder.build(single_pom,
>> ...).
>> We identified 2 relatively small limitations blocking m2e from adoption
>> ProjectBuilder.build(list_of_poms,...) that seems to just be missing
>> features compared to ProjectBuilder.build(single_pom...) because no-one
>> needed them to so far. We're covered these 2 issues in MNG-6529 and
>> MNG-6533; and there are pull requests open for both.
>> We'd appreciate if those can be targeted for review (and if everything
>> is
>> fine, merge) as part of next release.
>>
>> Thanks in advance.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: MNG-6533 and MNG-6529
Posted by Robert Scholte <rf...@apache.org>.
These PRs look fine, I'll run them on our CI servers.
thanks,
Robert
On Thu, 06 Dec 2018 10:41:58 +0100, Mickael Istria <mi...@redhat.com>
wrote:
> Hi all,
>
> As part of a major performance improvement in m2e, we'd like to use the
> ProjectBuilder.build(list_of_poms, ...) which drastically reduce CPU and
> RAM consumption compared to iterating on ProjectBuilder.build(single_pom,
> ...).
> We identified 2 relatively small limitations blocking m2e from adoption
> ProjectBuilder.build(list_of_poms,...) that seems to just be missing
> features compared to ProjectBuilder.build(single_pom...) because no-one
> needed them to so far. We're covered these 2 issues in MNG-6529 and
> MNG-6533; and there are pull requests open for both.
> We'd appreciate if those can be targeted for review (and if everything is
> fine, merge) as part of next release.
>
> Thanks in advance.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org