You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by "Timo Walther (JIRA)" <ji...@apache.org> on 2019/01/08 17:08:01 UTC

[jira] [Commented] (FLINK-11285) Change the modifier of CsvTableSourceFactoryBase.createTableSource and CsvTableSinkFactoryBase.createTableSink to private[flink]

    [ https://issues.apache.org/jira/browse/FLINK-11285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16737305#comment-16737305 ] 

Timo Walther commented on FLINK-11285:
--------------------------------------

Actually, users should not use these classes at all. Actually, they are mostly useful for debugging as they have no consistency guarantees.

> Change the modifier of CsvTableSourceFactoryBase.createTableSource and CsvTableSinkFactoryBase.createTableSink to private[flink]
> --------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: FLINK-11285
>                 URL: https://issues.apache.org/jira/browse/FLINK-11285
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API &amp; SQL
>            Reporter: Dian Fu
>            Assignee: Dian Fu
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> The modifier of CsvTableSourceFactoryBase.createTableSource and CsvTableSinkFactoryBase.createTableSink are currently protected. Users should not see these methods and they should use CsvBatchTableSinkFactory.createBatchTableSink, CsvAppendTableSinkFactory.createStreamTableSink, CsvBatchTableSourceFactory.createBatchTableSource or CsvAppendTableSourceFactory.createStreamTableSource instead.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)