[GitHub] [mynewt-blinky] sjanc opened a new pull request, #19: Use mynewt_main instead of main

["sjanc (via GitHub)" <gi...@apache.org>]

sjanc opened a new pull request, #19:
URL: https://github.com/apache/mynewt-blinky/pull/19

   Latest Mynewt has renamed main function.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [mynewt-blinky] sjanc merged pull request #19: Use mynewt_main instead of main

["sjanc (via GitHub)" <gi...@apache.org>]

sjanc merged PR #19:
URL: https://github.com/apache/mynewt-blinky/pull/19


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [mynewt-blinky] kasjer commented on a diff in pull request #19: Use mynewt_main instead of main

["kasjer (via GitHub)" <gi...@apache.org>]

kasjer commented on code in PR #19:
URL: https://github.com/apache/mynewt-blinky/pull/19#discussion_r1237421060


##########
apps/blinky/src/main.c:
##########
@@ -42,7 +42,7 @@ int g_led_pin;
  * @return int NOTE: this function should never return!
  */
 int
-main(int argc, char **argv)
+mynewt_main(int argc, char **argv)

Review Comment:
   With this change call to `mcu_sim_parse_args()` should not be needed any more



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org