You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by Norman Maurer <no...@apache.org> on 2008/01/14 07:23:32 UTC

Re: svn commit: r611722 - /james/server/trunk/spoolmanager-function/src/main/java/org/apache/james/transport/mailets/ToMultiRepository.java

Hi all,

I think this should get merged to 2.3 branch.. ok ?

bye
Norman


Am Montag, den 14.01.2008, 06:11 +0000 schrieb norman@apache.org:
> Author: norman
> Date: Sun Jan 13 22:11:05 2008
> New Revision: 611722
> 
> URL: http://svn.apache.org/viewvc?rev=611722&view=rev
> Log:
> ToMultiRepository doesn't resolve repository_name correctly. Thx to Kev Jackson for the patch. See JAMES-833
> 
> Modified:
>     james/server/trunk/spoolmanager-function/src/main/java/org/apache/james/transport/mailets/ToMultiRepository.java
> 
> Modified: james/server/trunk/spoolmanager-function/src/main/java/org/apache/james/transport/mailets/ToMultiRepository.java
> URL: http://svn.apache.org/viewvc/james/server/trunk/spoolmanager-function/src/main/java/org/apache/james/transport/mailets/ToMultiRepository.java?rev=611722&r1=611721&r2=611722&view=diff
> ==============================================================================
> --- james/server/trunk/spoolmanager-function/src/main/java/org/apache/james/transport/mailets/ToMultiRepository.java (original)
> +++ james/server/trunk/spoolmanager-function/src/main/java/org/apache/james/transport/mailets/ToMultiRepository.java Sun Jan 13 22:11:05 2008
> @@ -300,8 +300,15 @@
>          if (repositoryUrl == null) {
>              userInbox = mailServer.getUserInbox(userName);
>          } else {
> +            if (!repositoryUrl.endsWith("/")) {
> +        	    repositoryUrl += "/";
> +            }
> +        	        
> +            // find the username for delivery to that user - localname, ignore the rest
> +            String[] addressParts = userName.split("@");
> +        	        
>              StringBuffer destinationBuffer = new StringBuffer(192).append(
> -                    repositoryUrl).append(userName).append("/");
> +            repositoryUrl).append(addressParts[0]).append("/");
>              String destination = destinationBuffer.toString();
>              DefaultConfiguration mboxConf = new DefaultConfiguration(
>                      "repository", "generated:ToMultiRepository.getUserInbox()");
> 
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
> For additional commands, e-mail: server-dev-help@james.apache.org
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org


Re: svn commit: r611722 - /james/server/trunk/spoolmanager-function/src/main/java/org/apache/james/transport/mailets/ToMultiRepository.java

Posted by Stefano Bagnara <ap...@bago.org>.
Norman Maurer ha scritto:
> Hi all,
> 
> I think this should get merged to 2.3 branch.. ok ?

Yes, but there is also JAMES-832 to be fixed as related bug before 
backporting, IMHO.

Stefano

> bye
> Norman
> 
> 
> Am Montag, den 14.01.2008, 06:11 +0000 schrieb norman@apache.org:
>> Author: norman
>> Date: Sun Jan 13 22:11:05 2008
>> New Revision: 611722
>>
>> URL: http://svn.apache.org/viewvc?rev=611722&view=rev
>> Log:
>> ToMultiRepository doesn't resolve repository_name correctly. Thx to Kev Jackson for the patch. See JAMES-833
>>
>> Modified:
>>     james/server/trunk/spoolmanager-function/src/main/java/org/apache/james/transport/mailets/ToMultiRepository.java
>>
>> Modified: james/server/trunk/spoolmanager-function/src/main/java/org/apache/james/transport/mailets/ToMultiRepository.java
>> URL: http://svn.apache.org/viewvc/james/server/trunk/spoolmanager-function/src/main/java/org/apache/james/transport/mailets/ToMultiRepository.java?rev=611722&r1=611721&r2=611722&view=diff
>> ==============================================================================
>> --- james/server/trunk/spoolmanager-function/src/main/java/org/apache/james/transport/mailets/ToMultiRepository.java (original)
>> +++ james/server/trunk/spoolmanager-function/src/main/java/org/apache/james/transport/mailets/ToMultiRepository.java Sun Jan 13 22:11:05 2008
>> @@ -300,8 +300,15 @@
>>          if (repositoryUrl == null) {
>>              userInbox = mailServer.getUserInbox(userName);
>>          } else {
>> +            if (!repositoryUrl.endsWith("/")) {
>> +        	    repositoryUrl += "/";
>> +            }
>> +        	        
>> +            // find the username for delivery to that user - localname, ignore the rest
>> +            String[] addressParts = userName.split("@");
>> +        	        
>>              StringBuffer destinationBuffer = new StringBuffer(192).append(
>> -                    repositoryUrl).append(userName).append("/");
>> +            repositoryUrl).append(addressParts[0]).append("/");
>>              String destination = destinationBuffer.toString();
>>              DefaultConfiguration mboxConf = new DefaultConfiguration(
>>                      "repository", "generated:ToMultiRepository.getUserInbox()");



---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org