You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "Abacn (via GitHub)" <gi...@apache.org> on 2023/02/20 18:24:23 UTC

[GitHub] [beam] Abacn opened a new pull request, #25566: [Do not merge] Revert "Replace more uses of `ClassLoadingStrategy.Default.INJECTION` (#23210)"

Abacn opened a new pull request, #25566:
URL: https://github.com/apache/beam/pull/25566

   Investigate Java11/17 postcommit test failures
   
   This reverts commit 2b6291250f9b57bc3ce5f8e9407d234a6c89cd61.
   
   **Please** add a meaningful description for your change here
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Go tests](https://github.com/apache/beam/workflows/Go%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn commented on pull request #25566: Revert "Replace more uses of `ClassLoadingStrategy.Default.INJECTION` (#23210)"

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #25566:
URL: https://github.com/apache/beam/pull/25566#issuecomment-1438670839

   R: @aromanenko-dev 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn commented on pull request #25566: [Do not merge] Revert "Replace more uses of `ClassLoadingStrategy.Default.INJECTION` (#23210)"

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #25566:
URL: https://github.com/apache/beam/pull/25566#issuecomment-1438669914

   I am going to open this for now to get tests back green (and unblocks some other outstanding merging) CC: @cushon @lukecwik


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn commented on pull request #25566: [Do not merge] Revert "Replace more uses of `ClassLoadingStrategy.Default.INJECTION` (#23210)"

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #25566:
URL: https://github.com/apache/beam/pull/25566#issuecomment-1437408715

   Run SQL_Java17 PreCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn commented on pull request #25566: Revert "Replace more uses of `ClassLoadingStrategy.Default.INJECTION` (#23210)"

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #25566:
URL: https://github.com/apache/beam/pull/25566#issuecomment-1438674340

   Kafka_IO_Direct PreCommit known flake related to #25261


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] cushon commented on pull request #25566: Revert "Replace more uses of `ClassLoadingStrategy.Default.INJECTION` (#23210)"

Posted by "cushon (via GitHub)" <gi...@apache.org>.
cushon commented on PR #25566:
URL: https://github.com/apache/beam/pull/25566#issuecomment-1438963309

   I can reproduce with
   
   ```
   JAVA_HOME=$JAVA8_HOME ./gradlew -PdisableSpotlessCheck=true -PdisableCheckStyle=true -PcompileAndRunTestsWithJava17 -PskipCheckerFramework -Pjava17Home=$JAVA17_HOME --max-workers=8 -Dorg.gradle.jvmargs=-Xms2g -Dorg.gradle.jvmargs=-Xmx6g -Dorg.gradle.vfs.watch=false -Pdocker-pull-licenses clean  :sdks:java:extensions:sql:test
   ```
   
   ```
   java.lang.IllegalArgumentException: org.apache.beam.sdk.coders.Coder$ByteBuddy$3j3EZPM9 must be defined in the same package as org.apache.beam.sdk.schemas.Schema
   	at net.bytebuddy.dynamic.loading.ClassInjector$UsingLookup.injectRaw(ClassInjector.java:1635)
   	at net.bytebuddy.dynamic.loading.ClassInjector$AbstractBase.inject(ClassInjector.java:118)
   	at net.bytebuddy.dynamic.loading.ClassLoadingStrategy$UsingLookup.load(ClassLoadingStrategy.java:519)
   	at net.bytebuddy.dynamic.TypeResolutionStrategy$Passive.initialize(TypeResolutionStrategy.java:101)
   	at net.bytebuddy.dynamic.DynamicType$Default$Unloaded.load(DynamicType.java:6317)
   	at org.apache.beam.sdk.coders.RowCoderGenerator.generate(RowCoderGenerator.java:176)
   	at org.apache.beam.sdk.schemas.SchemaCoder.getDelegateCoder(SchemaCoder.java:117)
   ```
   
   I think most of the failures are related to this change from the original PR: https://github.com/apache/beam/pull/23210#discussion_r1102152818


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn commented on pull request #25566: [Do not merge] Revert "Replace more uses of `ClassLoadingStrategy.Default.INJECTION` (#23210)"

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #25566:
URL: https://github.com/apache/beam/pull/25566#issuecomment-1437409272

   Run SQL_Java11 PreCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn merged pull request #25566: Revert "Replace more uses of `ClassLoadingStrategy.Default.INJECTION` (#23210)"

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn merged PR #25566:
URL: https://github.com/apache/beam/pull/25566


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] lukecwik commented on pull request #25566: Revert "Replace more uses of `ClassLoadingStrategy.Default.INJECTION` (#23210)"

Posted by "lukecwik (via GitHub)" <gi...@apache.org>.
lukecwik commented on PR #25566:
URL: https://github.com/apache/beam/pull/25566#issuecomment-1438913930

   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] github-actions[bot] commented on pull request #25566: Revert "Replace more uses of `ClassLoadingStrategy.Default.INJECTION` (#23210)"

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #25566:
URL: https://github.com/apache/beam/pull/25566#issuecomment-1438672381

   Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] pabloem commented on pull request #25566: Revert "Replace more uses of `ClassLoadingStrategy.Default.INJECTION` (#23210)"

Posted by "pabloem (via GitHub)" <gi...@apache.org>.
pabloem commented on PR #25566:
URL: https://github.com/apache/beam/pull/25566#issuecomment-1438938903

   thanks @Abacn - indeed this looks like it's causing trouble : )


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] pabloem commented on pull request #25566: Revert "Replace more uses of `ClassLoadingStrategy.Default.INJECTION` (#23210)"

Posted by "pabloem (via GitHub)" <gi...@apache.org>.
pabloem commented on PR #25566:
URL: https://github.com/apache/beam/pull/25566#issuecomment-1438948412

   Run Java_Kafka_IO_Direct PreCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org