[jira] [Commented] (MESOS-6629) Add master validation of FrameworkInfo.roles.

["Jay Guo (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-6629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15692580#comment-15692580 ] 

Jay Guo commented on MESOS-6629:
--------------------------------

bq. {{FrameworkInfo.roles}} must not contain duplicate entries.
Do we want subscription to fail for duplicate roles or we simply deduplicate it and generate a warning? For the latter case we could change {{roles::parse}} to return std::set and reuse it for both framework and master's {{-- roles}}. Currently, master throws out warning for duplicate roles in {{-- roles}}: https://github.com/apache/mesos/blob/master/src/master/master.cpp#L662

> Add master validation of FrameworkInfo.roles.
> ---------------------------------------------
>
>                 Key: MESOS-6629
>                 URL: https://issues.apache.org/jira/browse/MESOS-6629
>             Project: Mesos
>          Issue Type: Task
>          Components: master
>            Reporter: Benjamin Mahler
>            Assignee: Jay Guo
>
> The master should disallow frameworks from subscribing based on the following:
> (1) Only one of {{FrameworkInfo.role}} and {{FrameworkInfo.roles}} must be set at a time.
> (2) If {{FrameworkInfo.roles}} is set, then the MULTI_ROLE framework capability must be provided.
> (3) If the MULTI_ROLE framework capability is provided, then {{FrameworkInfo.role}} must not be set.
> (4) {{FrameworkInfo.roles}} must not contain duplicate entries.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)