[GitHub] [superset] eschutho commented on a diff in pull request #19700: fix: remove expose

[GitBox <gi...@apache.org>]

eschutho commented on code in PR #19700:
URL: https://github.com/apache/superset/pull/19700#discussion_r851552148


##########
superset/databases/filters.py:
##########
@@ -69,8 +69,6 @@ class DatabaseUploadEnabledFilter(BaseFilter):  # pylint: disable=too-few-public
     def apply(self, query: Query, value: Any) -> Query:
         filtered_query = query.filter(Database.allow_file_upload)
 
-        database_perms = security_manager.user_view_menu_names("database_access")
-        schema_access_databases = can_access_databases("schema_access")

Review Comment:
   if I compare this filter to the actual csv file upload validator, the current code checks for 
   `security_manager.can_access_database(database)`
   and 
   schema in `database.get_schema_access_for_file_upload()`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org