You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Harikrishna Patnala <ha...@citrix.com> on 2014/03/11 16:17:38 UTC
[Merge] Virtual Router Service Failure Alerting
Hi,
I would like to merge the Virtual Router Service Failure Alerting feature into 4.4.
Feature was proposed on the dev list http://mail-archives.apache.org/mod_mbox/cloudstack-dev/201402.mbox/%3C7DE500C0-431B-42EE-BF5C-FBDB20113E17@citrix.com%3E
FS https://cwiki.apache.org/confluence/display/CLOUDSTACK/Virtual+Router+Service+Failure+Alerting
JIRA ticket for the bug https://issues.apache.org/jira/browse/CLOUDSTACK-6090.
Integration tests are added in the test script @ test/integration/smoke/test_VirtualRouter_alerts.py
Created a review request @ https://reviews.apache.org/r/19038/
Thank you,
Harikrishna
Re: [Merge] Virtual Router Service Failure Alerting
Posted by Harikrishna Patnala <ha...@citrix.com>.
Hi Hugo,
Thank you for asking this.
I ran the find bugs target on the files that I have changed and created, no bugs were found.
-Harikrishna
On 11-Mar-2014, at 9:01 pm, Hugo Trippaers <hu...@trippaers.nl> wrote:
> Harikrishna,
>
> Did you run the findbugs target on your changes? If not could you do that please, if there are any bugs marked a high importance it would cause build failures after we merge it.
>
> Cheers,
>
> Hugo
>
>
> On 11 mrt. 2014, at 16:17, Harikrishna Patnala <ha...@citrix.com> wrote:
>
>> Hi,
>> I would like to merge the Virtual Router Service Failure Alerting feature into 4.4.
>>
>>
>> Feature was proposed on the dev list http://mail-archives.apache.org/mod_mbox/cloudstack-dev/201402.mbox/%3C7DE500C0-431B-42EE-BF5C-FBDB20113E17@citrix.com%3E
>>
>> FS https://cwiki.apache.org/confluence/display/CLOUDSTACK/Virtual+Router+Service+Failure+Alerting
>>
>> JIRA ticket for the bug https://issues.apache.org/jira/browse/CLOUDSTACK-6090.
>>
>> Integration tests are added in the test script @ test/integration/smoke/test_VirtualRouter_alerts.py
>>
>> Created a review request @ https://reviews.apache.org/r/19038/
>>
>>
>> Thank you,
>> Harikrishna
>
Re: [Merge] Virtual Router Service Failure Alerting
Posted by Hugo Trippaers <hu...@trippaers.nl>.
Harikrishna,
Did you run the findbugs target on your changes? If not could you do that please, if there are any bugs marked a high importance it would cause build failures after we merge it.
Cheers,
Hugo
On 11 mrt. 2014, at 16:17, Harikrishna Patnala <ha...@citrix.com> wrote:
> Hi,
> I would like to merge the Virtual Router Service Failure Alerting feature into 4.4.
>
>
> Feature was proposed on the dev list http://mail-archives.apache.org/mod_mbox/cloudstack-dev/201402.mbox/%3C7DE500C0-431B-42EE-BF5C-FBDB20113E17@citrix.com%3E
>
> FS https://cwiki.apache.org/confluence/display/CLOUDSTACK/Virtual+Router+Service+Failure+Alerting
>
> JIRA ticket for the bug https://issues.apache.org/jira/browse/CLOUDSTACK-6090.
>
> Integration tests are added in the test script @ test/integration/smoke/test_VirtualRouter_alerts.py
>
> Created a review request @ https://reviews.apache.org/r/19038/
>
>
> Thank you,
> Harikrishna