[GitHub] matthiasblaesing commented on a change in pull request #1108: Upgraded ASM libraries to 7.0

[GitBox <gi...@apache.org>]

matthiasblaesing commented on a change in pull request #1108: Upgraded ASM libraries to 7.0
URL: https://github.com/apache/incubator-netbeans/pull/1108#discussion_r252417915
 
 

 ##########
 File path: java/lib.jshell.agent/nbproject/project.properties
 ##########
 @@ -21,5 +21,5 @@ javac.compilerargs=-Xlint -Xlint:-serial
 extra.module.files=modules/ext/nb-custom-jshell-probe.jar,modules/ext/nb-mod-jshell-probe.jar
 jnlp.indirect.jars=modules/ext/nb-custom-jshell-probe.jar,modules/ext/nb-mod-jshell-probe.jar
 
-agentsrc.asm.cp=${libs.asm.dir}/core/asm-all-5.0.1.jar
+agentsrc.asm.cp=${libs.asm.dir}/core/asm-7.0.jar
 
 Review comment:
   If I'm reading this correctly, the asm classes are packed into the `nb-mod-jshell-probe.jar` and loaded as a jvm agent. I'm not to deep into the agent creation, but to my understanding the agents are loaded before the main class and thus need their dependencies bundled. It would be good to see, if we really need all the asm artifacts bundled, or if a subset is enough (again I'm don't know asm enough).
   
   @sdedic it would be great if you could chime in.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists