You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Nicolas Malin (JIRA)" <ji...@apache.org> on 2014/09/01 21:24:20 UTC

[jira] [Updated] (OFBIZ-5734) Convert Product association entity CRUD service from simple to entity-auto

     [ https://issues.apache.org/jira/browse/OFBIZ-5734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nicolas Malin updated OFBIZ-5734:
---------------------------------
    Description: 
I converted CRUD service to entity-auto for :
 * GoodIdentification
 * ProductAttribute
 * ProductGeo
 * ProductMeter
 * ProductMaint
 * ProductGlAccount
 * ProductAssoc
 * ProductKeyword

There is a specific permission service on some simple method function like this :
{quote}
<set value="createProductMeter" field="callingMethodName"/>
<set value="CREATE" field="checkAction"/>
<call-simple-method method-name="checkProductRelatedPermission"/>
{quote}
replace by a call on service definition :
{quote} 
<permission-service service-name="productGenericPermission" main-action="CREATE"/>
{quote} 

I run manual test create/update/delete on each entity from product screen and 
I run ./ant clean-all load-demo run-tests with one error due to a status change on productKeyword. The reason that I added 
{quote}
<StatusValidChange condition="" statusId="KW_PENDING" statusIdTo="KW_APPROVED" transitionName="Review Approved"/>
<StatusValidChange condition="" statusId="KW_PENDING" statusIdTo="KW_DISAPPROVED" transitionName="Review Disapproved"/>
{quote}
To run test with successfull 

  was:
I converted CRUD service to entity-auto for :
 * GoodIdentification
 * ProductAttribute
 * ProductGeo
 * ProductMeter
 * ProductMaint
 * ProductGlAccount
 * ProductAssoc
 * ProductKeyword

There is a specific permission service on some simple method function like this :
{quote}
<set value="createProductMeter" field="callingMethodName"/>
<set value="CREATE" field="checkAction"/>
<call-simple-method method-name="checkProductRelatedPermission"/>
{quote}
replace by a call on service definition :
{quote} 
<permission-service service-name="productGenericPermission" main-action="CREATE" resource-description="createProductMeter"/>
{quote} 
The productGenericPermission service call checkProductRelatedPermission with as callingMethodName <- resource-description

I run manual test create/update/delete on each entity from product screen and 
I run ./ant clean-all load-demo run-tests with one error due to a status change on productKeyword. The reason that I added 
{quote}
<StatusValidChange condition="" statusId="KW_PENDING" statusIdTo="KW_APPROVED" transitionName="Review Approved"/>
<StatusValidChange condition="" statusId="KW_PENDING" statusIdTo="KW_DISAPPROVED" transitionName="Review Disapproved"/>
{quote}
To run test with successfull 


> Convert Product association entity CRUD service from simple to entity-auto
> --------------------------------------------------------------------------
>
>                 Key: OFBIZ-5734
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5734
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: product
>    Affects Versions: Trunk
>            Reporter: Nicolas Malin
>            Priority: Trivial
>              Labels: crud, entity-auto, product
>         Attachments: OFBIZ-5734.patch
>
>
> I converted CRUD service to entity-auto for :
>  * GoodIdentification
>  * ProductAttribute
>  * ProductGeo
>  * ProductMeter
>  * ProductMaint
>  * ProductGlAccount
>  * ProductAssoc
>  * ProductKeyword
> There is a specific permission service on some simple method function like this :
> {quote}
> <set value="createProductMeter" field="callingMethodName"/>
> <set value="CREATE" field="checkAction"/>
> <call-simple-method method-name="checkProductRelatedPermission"/>
> {quote}
> replace by a call on service definition :
> {quote} 
> <permission-service service-name="productGenericPermission" main-action="CREATE"/>
> {quote} 
> I run manual test create/update/delete on each entity from product screen and 
> I run ./ant clean-all load-demo run-tests with one error due to a status change on productKeyword. The reason that I added 
> {quote}
> <StatusValidChange condition="" statusId="KW_PENDING" statusIdTo="KW_APPROVED" transitionName="Review Approved"/>
> <StatusValidChange condition="" statusId="KW_PENDING" statusIdTo="KW_DISAPPROVED" transitionName="Review Disapproved"/>
> {quote}
> To run test with successfull 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)