You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/11/17 18:23:56 UTC
[GitHub] [yunikorn-k8shim] craigcondit opened a new pull request, #484: [YUNIKORN-1411] Upgrade Kubernetes dependency to v1.23.14
craigcondit opened a new pull request, #484:
URL: https://github.com/apache/yunikorn-k8shim/pull/484
### What is this PR for?
Update kubernetes dependency to v1.23.14.
### What type of PR is it?
* [ ] - Bug Fix
* [x] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1411
### How should this be tested?
Existing unit / e2e tests.
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] codecov[bot] commented on pull request #484: [YUNIKORN-1411] Upgrade Kubernetes dependency to v1.23.14
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #484:
URL: https://github.com/apache/yunikorn-k8shim/pull/484#issuecomment-1319061575
# [Codecov](https://codecov.io/gh/apache/yunikorn-k8shim/pull/484?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#484](https://codecov.io/gh/apache/yunikorn-k8shim/pull/484?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (462ac1e) into [master](https://codecov.io/gh/apache/yunikorn-k8shim/commit/2ebc10c8023fb5ce828010b2235c497f0e0489e9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2ebc10c) will **decrease** coverage by `0.92%`.
> The diff coverage is `60.46%`.
```diff
@@ Coverage Diff @@
## master #484 +/- ##
==========================================
- Coverage 69.30% 68.38% -0.93%
==========================================
Files 42 43 +1
Lines 7592 7746 +154
==========================================
+ Hits 5262 5297 +35
- Misses 2153 2265 +112
- Partials 177 184 +7
```
| [Impacted Files](https://codecov.io/gh/apache/yunikorn-k8shim/pull/484?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/cache/context.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/484/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NhY2hlL2NvbnRleHQuZ28=) | `39.86% <0.00%> (ø)` | |
| [pkg/plugin/admissioncontrollers/webhook/webhook.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/484/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3BsdWdpbi9hZG1pc3Npb25jb250cm9sbGVycy93ZWJob29rL3dlYmhvb2suZ28=) | `0.00% <0.00%> (-40.00%)` | :arrow_down: |
| [...missioncontrollers/webhook/annotation/usergroup.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/484/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3BsdWdpbi9hZG1pc3Npb25jb250cm9sbGVycy93ZWJob29rL2Fubm90YXRpb24vdXNlcmdyb3VwLmdv) | `95.34% <50.00%> (-4.66%)` | :arrow_down: |
| [...missioncontrollers/webhook/admission\_controller.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/484/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3BsdWdpbi9hZG1pc3Npb25jb250cm9sbGVycy93ZWJob29rL2FkbWlzc2lvbl9jb250cm9sbGVyLmdv) | `62.56% <56.75%> (-8.22%)` | :arrow_down: |
| [...lugin/admissioncontrollers/webhook/conf/am\_conf.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/484/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3BsdWdpbi9hZG1pc3Npb25jb250cm9sbGVycy93ZWJob29rL2NvbmYvYW1fY29uZi5nbw==) | `62.03% <62.03%> (ø)` | |
| [...in/admissioncontrollers/webhook/webhook\_manager.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/484/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3BsdWdpbi9hZG1pc3Npb25jb250cm9sbGVycy93ZWJob29rL3dlYmhvb2tfbWFuYWdlci5nbw==) | `76.86% <88.46%> (+0.36%)` | :arrow_up: |
| [pkg/dispatcher/dispatcher.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/484/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2Rpc3BhdGNoZXIvZGlzcGF0Y2hlci5nbw==) | `74.82% <0.00%> (-1.40%)` | :arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] wilfred-s closed pull request #484: [YUNIKORN-1411] Upgrade Kubernetes dependency to v1.23.14
Posted by GitBox <gi...@apache.org>.
wilfred-s closed pull request #484: [YUNIKORN-1411] Upgrade Kubernetes dependency to v1.23.14
URL: https://github.com/apache/yunikorn-k8shim/pull/484
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org