You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@uima.apache.org by cw...@apache.org on 2018/05/02 13:46:09 UTC

svn commit: r1830757 - in /uima/uima-ducc/trunk/uima-ducc-pullservice/src/main/java/org/apache/uima/ducc/ps/service/main: PullService.java ServiceWrapper.java

Author: cwiklik
Date: Wed May  2 13:46:09 2018
New Revision: 1830757

URL: http://svn.apache.org/viewvc?rev=1830757&view=rev
Log:
UIMA-5756 cleanup

Modified:
    uima/uima-ducc/trunk/uima-ducc-pullservice/src/main/java/org/apache/uima/ducc/ps/service/main/PullService.java
    uima/uima-ducc/trunk/uima-ducc-pullservice/src/main/java/org/apache/uima/ducc/ps/service/main/ServiceWrapper.java

Modified: uima/uima-ducc/trunk/uima-ducc-pullservice/src/main/java/org/apache/uima/ducc/ps/service/main/PullService.java
URL: http://svn.apache.org/viewvc/uima/uima-ducc/trunk/uima-ducc-pullservice/src/main/java/org/apache/uima/ducc/ps/service/main/PullService.java?rev=1830757&r1=1830756&r2=1830757&view=diff
==============================================================================
--- uima/uima-ducc/trunk/uima-ducc-pullservice/src/main/java/org/apache/uima/ducc/ps/service/main/PullService.java (original)
+++ uima/uima-ducc/trunk/uima-ducc-pullservice/src/main/java/org/apache/uima/ducc/ps/service/main/PullService.java Wed May  2 13:46:09 2018
@@ -156,7 +156,7 @@ public class PullService implements ISer
 
 			// contract is that the service will block in this method until
 			// all process threads initialize. Use a latch to block until this
-			// happens. Each process thread will count this down after intialization
+			// happens. Each process thread will count this down after initialization
 			if ( threadsReady == null ) {
 				this.threadsReady = new CountDownLatch(scaleout);
 			}
@@ -180,7 +180,7 @@ public class PullService implements ISer
 					   
 			
 			// first initialize Processors. The ServiceThreadFactory creates 
-			// as many threads as needed
+			// as many threads as defined in 'scaleout'
 			threadPool = 
 					new ScheduledThreadPoolExecutor(scaleout, new ServiceThreadFactory());
 			

Modified: uima/uima-ducc/trunk/uima-ducc-pullservice/src/main/java/org/apache/uima/ducc/ps/service/main/ServiceWrapper.java
URL: http://svn.apache.org/viewvc/uima/uima-ducc/trunk/uima-ducc-pullservice/src/main/java/org/apache/uima/ducc/ps/service/main/ServiceWrapper.java?rev=1830757&r1=1830756&r2=1830757&view=diff
==============================================================================
--- uima/uima-ducc/trunk/uima-ducc-pullservice/src/main/java/org/apache/uima/ducc/ps/service/main/ServiceWrapper.java (original)
+++ uima/uima-ducc/trunk/uima-ducc-pullservice/src/main/java/org/apache/uima/ducc/ps/service/main/ServiceWrapper.java Wed May  2 13:46:09 2018
@@ -67,7 +67,7 @@ public class ServiceWrapper {
 		if ( serviceConfiguration.getCustomProcessorClass() != null ) {
 			try {
 			Class<?> clz = Class.forName(serviceConfiguration.getCustomProcessorClass());
-			// the custom processor must implement IServiceProcessor
+			// custom processor must implement IServiceProcessor
 			if ( !IServiceProcessor.class.isAssignableFrom(clz) ) {
 				throw new ServiceInitializationException(serviceConfiguration.getCustomProcessorClass()+" Processor Class does not implement IServiceProcessor ");
 			}
@@ -136,8 +136,6 @@ public class ServiceWrapper {
 
 		}
 		
-		// String tasURL = "http://localhost:8080/test";
-
 
 		service.initialize();