You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@apr.apache.org by Ruediger Pluem <rp...@apache.org> on 2024/02/08 15:56:47 UTC

Re: svn commit: r1915658 - /apr/apr/trunk/test/testbuckets.c


On 2/8/24 4:49 PM, jorton@apache.org wrote:
> Author: jorton
> Date: Thu Feb  8 15:49:14 2024
> New Revision: 1915658
> 
> URL: http://svn.apache.org/viewvc?rev=1915658&view=rev
> Log:
> * buckets/apr_brigade.c (apr_brigade_split_line): After finding an LF,
>   only split the bucket if the LF is not the last character in the
>   data.
> 
> * test/testbuckets.c (test_splitline_exactly): New test.
> 
> PR: 64273
> Github: closes #53
> Submitted by: Barnim Dzwillo <dzwillo strato.de>, jorton
> 
> Modified:
>     apr/apr/trunk/test/testbuckets.c

Did you miss to commit the changes to buckets/apr_brigade.c?

Regards

Rüdiger

Re: svn commit: r1915658 - /apr/apr/trunk/test/testbuckets.c

Posted by Joe Orton <jo...@redhat.com>.

On Thu, Feb 08, 2024 at 04:56:47PM +0100, Ruediger Pluem wrote:
> On 2/8/24 4:49 PM, jorton@apache.org wrote:
> > Author: jorton
> > Date: Thu Feb  8 15:49:14 2024
> > New Revision: 1915658
...
> Did you miss to commit the changes to buckets/apr_brigade.c?

Ooops! Yup, fixed in r1915661 - thanks a lot.

At least this proves the test case works :)

Regards, Joe