You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Stefan Simik (JIRA)" <ji...@apache.org> on 2008/06/11 23:40:45 UTC
[jira] Created: (WICKET-1696) CaptchaImageResource - should take an
IModel instead of String for captcha-text
CaptchaImageResource - should take an IModel<String> instead of String for captcha-text
---------------------------------------------------------------------------------------
Key: WICKET-1696
URL: https://issues.apache.org/jira/browse/WICKET-1696
Project: Wicket
Issue Type: Improvement
Components: wicket-extensions
Reporter: Stefan Simik
Fix For: 1.4-M2
CaptchaImageResource - should take an IModel<String> instead of String for captcha-text
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1696) CaptchaImageResource - should take
an IModel instead of String for captcha-text
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12606827#action_12606827 ]
Igor Vaynberg commented on WICKET-1696:
---------------------------------------
you mean the challenge id? as far as i can tell it generates the text automatically
> CaptchaImageResource - should take an IModel<String> instead of String for captcha-text
> ---------------------------------------------------------------------------------------
>
> Key: WICKET-1696
> URL: https://issues.apache.org/jira/browse/WICKET-1696
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-extensions
> Reporter: Stefan Simik
> Assignee: Igor Vaynberg
> Fix For: 1.4-M3
>
> Original Estimate: 0.33h
> Remaining Estimate: 0.33h
>
> CaptchaImageResource - should take an IModel<String> instead of String for captcha-text
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1696) CaptchaImageResource - should take an
IModel instead of String for captcha-text
Posted by "Martijn Dashorst (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martijn Dashorst updated WICKET-1696:
-------------------------------------
Fix Version/s: (was: 1.4-M3)
1.4-M4
Moved to next milestone release.
> CaptchaImageResource - should take an IModel<String> instead of String for captcha-text
> ---------------------------------------------------------------------------------------
>
> Key: WICKET-1696
> URL: https://issues.apache.org/jira/browse/WICKET-1696
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-extensions
> Reporter: Stefan Simik
> Assignee: Igor Vaynberg
> Fix For: 1.4-M4
>
> Original Estimate: 0.33h
> Remaining Estimate: 0.33h
>
> CaptchaImageResource - should take an IModel<String> instead of String for captcha-text
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WICKET-1696) CaptchaImageResource - should take
an IModel instead of String for captcha-text
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg reassigned WICKET-1696:
-------------------------------------
Assignee: Igor Vaynberg
> CaptchaImageResource - should take an IModel<String> instead of String for captcha-text
> ---------------------------------------------------------------------------------------
>
> Key: WICKET-1696
> URL: https://issues.apache.org/jira/browse/WICKET-1696
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-extensions
> Reporter: Stefan Simik
> Assignee: Igor Vaynberg
> Fix For: 1.4-M3
>
> Original Estimate: 0.33h
> Remaining Estimate: 0.33h
>
> CaptchaImageResource - should take an IModel<String> instead of String for captcha-text
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1696) CaptchaImageResource - should take
an IModel instead of String for captcha-text
Posted by "James Carman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12604666#action_12604666 ]
James Carman commented on WICKET-1696:
--------------------------------------
Should this be moved to m3, since m2 is already out the door?
> CaptchaImageResource - should take an IModel<String> instead of String for captcha-text
> ---------------------------------------------------------------------------------------
>
> Key: WICKET-1696
> URL: https://issues.apache.org/jira/browse/WICKET-1696
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-extensions
> Reporter: Stefan Simik
> Fix For: 1.4-M2
>
> Original Estimate: 0.33h
> Remaining Estimate: 0.33h
>
> CaptchaImageResource - should take an IModel<String> instead of String for captcha-text
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1696) CaptchaImageResource - should take an
IModel instead of String for captcha-text
Posted by "Stefan Simik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stefan Simik updated WICKET-1696:
---------------------------------
Fix Version/s: (was: 1.4-M2)
1.4-M3
> CaptchaImageResource - should take an IModel<String> instead of String for captcha-text
> ---------------------------------------------------------------------------------------
>
> Key: WICKET-1696
> URL: https://issues.apache.org/jira/browse/WICKET-1696
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-extensions
> Reporter: Stefan Simik
> Fix For: 1.4-M3
>
> Original Estimate: 0.33h
> Remaining Estimate: 0.33h
>
> CaptchaImageResource - should take an IModel<String> instead of String for captcha-text
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1696) CaptchaImageResource - should take
an IModel instead of String for captcha-text
Posted by "Stefan Simik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12604677#action_12604677 ]
Stefan Simik commented on WICKET-1696:
--------------------------------------
Sure ;) thanx
I changed the fix version.
> CaptchaImageResource - should take an IModel<String> instead of String for captcha-text
> ---------------------------------------------------------------------------------------
>
> Key: WICKET-1696
> URL: https://issues.apache.org/jira/browse/WICKET-1696
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-extensions
> Reporter: Stefan Simik
> Fix For: 1.4-M3
>
> Original Estimate: 0.33h
> Remaining Estimate: 0.33h
>
> CaptchaImageResource - should take an IModel<String> instead of String for captcha-text
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1696) CaptchaImageResource - should take an
IModel instead of String for captcha-text
Posted by "Ryan Gravener (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ryan Gravener updated WICKET-1696:
----------------------------------
Attachment: captchawithimodel.patch
captchawithimodel.patch allows the user to pass in an imodel or a string to give them more control over the challenge.
> CaptchaImageResource - should take an IModel<String> instead of String for captcha-text
> ---------------------------------------------------------------------------------------
>
> Key: WICKET-1696
> URL: https://issues.apache.org/jira/browse/WICKET-1696
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-extensions
> Reporter: Stefan Simik
> Assignee: Igor Vaynberg
> Fix For: 1.4-M4
>
> Attachments: captchawithimodel.patch
>
> Original Estimate: 0.33h
> Remaining Estimate: 0.33h
>
> CaptchaImageResource - should take an IModel<String> instead of String for captcha-text
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-1696) CaptchaImageResource - should take
an IModel instead of String for captcha-text
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg resolved WICKET-1696.
-----------------------------------
Resolution: Fixed
> CaptchaImageResource - should take an IModel<String> instead of String for captcha-text
> ---------------------------------------------------------------------------------------
>
> Key: WICKET-1696
> URL: https://issues.apache.org/jira/browse/WICKET-1696
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-extensions
> Reporter: Stefan Simik
> Assignee: Igor Vaynberg
> Fix For: 1.4-M4
>
> Attachments: captchawithimodel.patch
>
> Original Estimate: 0.33h
> Remaining Estimate: 0.33h
>
> CaptchaImageResource - should take an IModel<String> instead of String for captcha-text
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1696) CaptchaImageResource - should take
an IModel instead of String for captcha-text
Posted by "Stefan Simik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12606830#action_12606830 ]
Stefan Simik commented on WICKET-1696:
--------------------------------------
jj, I mean the challenge id.
The problematic is CaptchaImageResource, which has a constructor, that takes static String.
Now, it's not possible to change the text on captcha image on page reload - for example.
There should be a layer of abstraction - model, which can return always the same string (the same, as it is now),
or it can generate each time something different - It is possible to implement own dynamic logic in generating challenge ID.
> CaptchaImageResource - should take an IModel<String> instead of String for captcha-text
> ---------------------------------------------------------------------------------------
>
> Key: WICKET-1696
> URL: https://issues.apache.org/jira/browse/WICKET-1696
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-extensions
> Reporter: Stefan Simik
> Assignee: Igor Vaynberg
> Fix For: 1.4-M3
>
> Original Estimate: 0.33h
> Remaining Estimate: 0.33h
>
> CaptchaImageResource - should take an IModel<String> instead of String for captcha-text
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.