[GitHub] [geode] dschneider-pivotal opened pull request #4484: GEODE-7424: create index on group

["dschneider-pivotal (GitHub)" <gi...@apache.org>]

Now makes sure that create index on a group works correctly.

Co-authored-by: Joris Melchior <jo...@gmail.com>
Co-authored-by: Darrel Schneider <ds...@pivotal.io>

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/4484 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jinmeiliao commented on pull request #4484: GEODE-7424: create index on group

["jinmeiliao (GitHub)" <gi...@apache.org>]

probably injecting RegionConfigManager and use the `get` method on that would be easier to find the existence of the region.

[ Full content available at: https://github.com/apache/geode/pull/4484 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jinmeiliao closed pull request #4484: GEODE-7424: create index on group

["jinmeiliao (GitHub)" <gi...@apache.org>]

[ pull request closed by jinmeiliao ]

[ Full content available at: https://github.com/apache/geode/pull/4484 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] dschneider-pivotal commented on pull request #4484: GEODE-7424: create index on group

["dschneider-pivotal (GitHub)" <gi...@apache.org>]

I think it would actually be more work. RegionConfigManager.get(Region config, CacheConfig existing) still needs a CacheConfig so we still need to get that from the persistenceService and we would also need to create a "Region" instance and set its name. So I think the current code is easier.

[ Full content available at: https://github.com/apache/geode/pull/4484 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org