You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org> on 2024/06/12 15:46:08 UTC
[Impala-ASF-CR] IMPALA-13155: Smallify strings values in all Tuple::Deepcopy()
Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21508
Change subject: IMPALA-13155: Smallify strings values in all Tuple::Deepcopy()
......................................................................
IMPALA-13155: Smallify strings values in all Tuple::Deepcopy()
Currently "Tuple::DeepCopy(const TupleDescriptor& desc, char** data,
int* offset, bool convert_ptrs)" does not try to smallify string values,
although it could safely do that as it creates new string values. We use
that version of DeepCopy when we BROADCAST data between fragments, so
smallifying on that path can be beneficial.
TODO: measurements
Change-Id: I5822243629e198e56006d81a9e5077926f391a74
---
M be/src/runtime/tuple.cc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/08/21508/1
--
To view, visit http://gerrit.cloudera.org:8080/21508
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5822243629e198e56006d81a9e5077926f391a74
Gerrit-Change-Number: 21508
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] WIP: IMPALA-13155: Smallify strings values in all Tuple::Deepcopy()
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has abandoned this change. ( http://gerrit.cloudera.org:8080/21508 )
Change subject: WIP: IMPALA-13155: Smallify strings values in all Tuple::Deepcopy()
......................................................................
Abandoned
--
To view, visit http://gerrit.cloudera.org:8080/21508
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I5822243629e198e56006d81a9e5077926f391a74
Gerrit-Change-Number: 21508
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-13155: Smallify strings values in all Tuple::Deepcopy()
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21508
to look at the new patch set (#2).
Change subject: IMPALA-13155: Smallify strings values in all Tuple::Deepcopy()
......................................................................
IMPALA-13155: Smallify strings values in all Tuple::Deepcopy()
Currently "Tuple::DeepCopy(const TupleDescriptor& desc, char** data,
int* offset, bool convert_ptrs)" does not try to smallify string values,
although it could safely do that as it creates new string values. We use
that version of DeepCopy when we BROADCAST data between fragments, so
smallifying on that path can be beneficial.
TODO: measurements
Change-Id: I5822243629e198e56006d81a9e5077926f391a74
---
M be/src/runtime/tuple.cc
1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/08/21508/2
--
To view, visit http://gerrit.cloudera.org:8080/21508
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5822243629e198e56006d81a9e5077926f391a74
Gerrit-Change-Number: 21508
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] WIP: IMPALA-13155: Smallify strings values in all Tuple::Deepcopy()
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21508 )
Change subject: WIP: IMPALA-13155: Smallify strings values in all Tuple::Deepcopy()
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/16322/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/21508
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5822243629e198e56006d81a9e5077926f391a74
Gerrit-Change-Number: 21508
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 12 Jun 2024 16:15:55 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] WIP: IMPALA-13155: Smallify strings values in all Tuple::Deepcopy()
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21508 )
Change subject: WIP: IMPALA-13155: Smallify strings values in all Tuple::Deepcopy()
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/16321/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/21508
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5822243629e198e56006d81a9e5077926f391a74
Gerrit-Change-Number: 21508
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 12 Jun 2024 16:10:38 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] WIP: IMPALA-13155: Smallify strings values in all Tuple::Deepcopy()
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21508 )
Change subject: WIP: IMPALA-13155: Smallify strings values in all Tuple::Deepcopy()
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/16323/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/21508
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5822243629e198e56006d81a9e5077926f391a74
Gerrit-Change-Number: 21508
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 12 Jun 2024 16:28:46 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] WIP: IMPALA-13155: Smallify strings values in all Tuple::Deepcopy()
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21508
to look at the new patch set (#3).
Change subject: WIP: IMPALA-13155: Smallify strings values in all Tuple::Deepcopy()
......................................................................
WIP: IMPALA-13155: Smallify strings values in all Tuple::Deepcopy()
Currently "Tuple::DeepCopy(const TupleDescriptor& desc, char** data,
int* offset, bool convert_ptrs)" does not try to smallify string values,
although it could safely do that as it creates new string values. We use
that version of DeepCopy when we BROADCAST data between fragments, so
smallifying on that path can be beneficial.
TODO: measurements
Change-Id: I5822243629e198e56006d81a9e5077926f391a74
---
M be/src/runtime/tuple.cc
1 file changed, 6 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/08/21508/3
--
To view, visit http://gerrit.cloudera.org:8080/21508
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5822243629e198e56006d81a9e5077926f391a74
Gerrit-Change-Number: 21508
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>