You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@velocity.apache.org by cb...@apache.org on 2010/09/10 12:50:46 UTC
svn commit: r995744 -
/velocity/tools/trunk/src/main/java/org/apache/velocity/tools/view/VelocityViewServlet.java
Author: cbrisson
Date: Fri Sep 10 10:50:46 2010
New Revision: 995744
URL: http://svn.apache.org/viewvc?rev=995744&view=rev
Log:
correct and better handling of commited responses in error()
Modified:
velocity/tools/trunk/src/main/java/org/apache/velocity/tools/view/VelocityViewServlet.java
Modified: velocity/tools/trunk/src/main/java/org/apache/velocity/tools/view/VelocityViewServlet.java
URL: http://svn.apache.org/viewvc/velocity/tools/trunk/src/main/java/org/apache/velocity/tools/view/VelocityViewServlet.java?rev=995744&r1=995743&r2=995744&view=diff
==============================================================================
--- velocity/tools/trunk/src/main/java/org/apache/velocity/tools/view/VelocityViewServlet.java (original)
+++ velocity/tools/trunk/src/main/java/org/apache/velocity/tools/view/VelocityViewServlet.java Fri Sep 10 10:50:46 2010
@@ -337,14 +337,16 @@ public class VelocityViewServlet extends
HttpServletResponse response,
Throwable e)
{
- if (!response.isCommitted())
+ String path = ServletUtils.getPath(request);
+ if (response.isCommitted())
{
+ getLog().error("An error occured but the response headers have already been sent.");
+ getLog().error("Error processing a template for path '" + path + "'", e);
return;
}
try
{
- String path = ServletUtils.getPath(request);
getLog().error("Error processing a template for path '" + path + "'", e);
StringBuilder html = new StringBuilder();
html.append("<html>\n");