You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/04/28 11:49:43 UTC
[GitHub] [shardingsphere] jingshanglu opened a new pull request #5372: Issue 4683
jingshanglu opened a new pull request #5372:
URL: https://github.com/apache/shardingsphere/pull/5372
Fixes #ISSUSE_ID.
Changes proposed in this pull request:
- fix for mysql tcl
- ref mysql dml
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero commented on a change in pull request #5372: fix for mysql tcl
Posted by GitBox <gi...@apache.org>.
tristaZero commented on a change in pull request #5372:
URL: https://github.com/apache/shardingsphere/pull/5372#discussion_r417034984
##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-test/src/test/java/org/apache/shardingsphere/sql/parser/integrate/engine/SQLParserParameterizedTest.java
##########
@@ -127,9 +127,6 @@ private static boolean isPlaceholderWithoutParameter(final Object[] sqlTestParam
@Test
public void assertSupportedSQL() {
- if ("select_pagination_with_row_number_for_greater_than_and_equal".equals(sqlCaseId)) {
Review comment:
aha, self-righting? Like!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] coveralls commented on pull request #5372: fix for mysql tcl
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #5372:
URL: https://github.com/apache/shardingsphere/pull/5372#issuecomment-620596247
## Pull Request Test Coverage Report for [Build 11339](https://coveralls.io/builds/30400025)
* **0** of **0** changed or added relevant lines in **0** files are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage remained the same at **57.394%**
---
| Totals | [](https://coveralls.io/builds/30400025) |
| :-- | --: |
| Change from base [Build 11336](https://coveralls.io/builds/30398569): | 0.0% |
| Covered Lines: | 11880 |
| Relevant Lines: | 20699 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org