[jira] [Commented] (LUCENE-7996) Should we require positive scores?

["Yonik Seeley (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-7996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641096#comment-16641096 ] 

Yonik Seeley commented on LUCENE-7996:
--------------------------------------

{quote}Agreed some users are going to be annoyed by the impact of this change. I wouldn't have considered it if it wasn't a requirement to get speedups in the order of what we are observing on LUCENE-4100 and LUCENE-7993.
{quote}

But maxscore/impact optimizations can only be used in certain circumstances anyway, right?  Given that we need fallback to score-all for things that aren't supported, falling back rather than prohibiting negative scores would avoid the back compat breaks.

> Should we require positive scores?
> ----------------------------------
>
>                 Key: LUCENE-7996
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7996
>             Project: Lucene - Core
>          Issue Type: Wish
>            Reporter: Adrien Grand
>            Priority: Minor
>             Fix For: master (8.0)
>
>         Attachments: LUCENE-7996.patch, LUCENE-7996.patch, LUCENE-7996.patch
>
>
> Having worked on MAXSCORE recently, things would be simpler if we required that scores are positive. Practically, this would mean 
>  - forbidding/fixing similarities that may produce negative scores (we have some of them)
>  - forbidding things like negative boosts
> So I'd be curious to have opinions whether this would be a sane requirement or whether we need to be able to cope with negative scores eg. because some similarities that we want to support produce negative scores by design.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org