You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/03/29 08:03:52 UTC
[GitHub] [camel-website] psingh587 opened a new pull request #286:
CAMEL-14797: Fixes The Quick Look Up issue
psingh587 opened a new pull request #286: CAMEL-14797: Fixes The Quick Look Up issue
URL: https://github.com/apache/camel-website/pull/286
-This PR, I have tried to solve the issue related to Quick Look Up Search Result appearance. An extra arrow used to appear.
In this I have removed the appearance of arrows when anything is typed in the search box which eradicates the issue of the messy toggle. And the arrows restore to its original place once the text in the search box is NIL.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on issue #286: CAMEL-14797:
Fixes The Quick Look Up issue
Posted by GitBox <gi...@apache.org>.
zregvart commented on issue #286: CAMEL-14797: Fixes The Quick Look Up issue
URL: https://github.com/apache/camel-website/pull/286#issuecomment-607126556
Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request
#286: CAMEL-14797: Fixes The Quick Look Up issue
Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #286: CAMEL-14797: Fixes The Quick Look Up issue
URL: https://github.com/apache/camel-website/pull/286#discussion_r400469716
##########
File path: antora-ui-camel/src/js/05-nav-search.js
##########
@@ -6,9 +6,18 @@ document.addEventListener('DOMContentLoaded', function () {
if (!navSearch) {
return
}
-
+ var navToggle = document.querySelectorAll('.nav-item-toggle')
var navLinks = document.querySelectorAll('.nav-link')
navSearch.addEventListener('keyup', function () {
+ if (navSearch.value === '') {
+ for (var b = 0; b < navToggle.length; b++) {
Review comment:
```suggestion
for (let i = 0; i < navToggle.length; i++) {
```
Or you can use `https://developer.mozilla.org/en-US/docs/Web/API/NodeList/forEach`
Could also use single loop with `navSearch.value === '' ? 'block' : 'none'` here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on a change in pull request
#286: CAMEL-14797: Fixes The Quick Look Up issue
Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #286: CAMEL-14797: Fixes The Quick Look Up issue
URL: https://github.com/apache/camel-website/pull/286#discussion_r400471033
##########
File path: antora-ui-camel/src/js/05-nav-search.js
##########
@@ -6,9 +6,18 @@ document.addEventListener('DOMContentLoaded', function () {
if (!navSearch) {
return
}
-
+ var navToggle = document.querySelectorAll('.nav-item-toggle')
var navLinks = document.querySelectorAll('.nav-link')
navSearch.addEventListener('keyup', function () {
+ if (navSearch.value === '') {
+ for (var b = 0; b < navToggle.length; b++) {
+ navToggle[b].style.display = 'block'
+ }
+ } else {
+ for (b = 0; b < navToggle.length; b++) {
Review comment:
Declare variable using `var`/`let`. Could bring `b` into global scope.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart merged pull request #286: CAMEL-14797:
Fixes The Quick Look Up issue
Posted by GitBox <gi...@apache.org>.
zregvart merged pull request #286: CAMEL-14797: Fixes The Quick Look Up issue
URL: https://github.com/apache/camel-website/pull/286
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] psingh587 commented on issue #286: CAMEL-14797:
Fixes The Quick Look Up issue
Posted by GitBox <gi...@apache.org>.
psingh587 commented on issue #286: CAMEL-14797: Fixes The Quick Look Up issue
URL: https://github.com/apache/camel-website/pull/286#issuecomment-606603849
@zregvart Made the changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services