You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "ivandika3 (via GitHub)" <gi...@apache.org> on 2025/06/21 02:50:18 UTC
Re: [PR] HDDS-13308. OM should expose Ratis config for increasing pending write limits [ozone]
ivandika3 commented on code in PR #8668:
URL: https://github.com/apache/ozone/pull/8668#discussion_r2159828597
##########
hadoop-hdds/common/src/main/resources/ozone-default.xml:
##########
@@ -2183,6 +2183,20 @@
<description>Byte limit for Raft's Log Worker queue.
</description>
</property>
+ <property>
+ <name>ozone.om.ratis.pending.write.byte-limit</name>
+ <value>32MB</value>
Review Comment:
Typo: this should be 64MB
##########
hadoop-hdds/common/src/main/resources/ozone-default.xml:
##########
@@ -2183,6 +2183,20 @@
<description>Byte limit for Raft's Log Worker queue.
</description>
</property>
+ <property>
+ <name>ozone.om.ratis.pending.write.byte-limit</name>
+ <value>32MB</value>
+ <tag>OZONE, DEBUG, OM, RATIS</tag>
+ <description>Raft's Pending writes Byte limit.
Review Comment:
We can change the description to follow https://github.com/apache/ratis/blob/master/ratis-docs/src/site/markdown/configurations.md , same with the other configuration.
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/OMConfigKeys.java:
##########
@@ -199,6 +199,14 @@ public final class OMConfigKeys {
"ozone.om.ratis.log.appender.queue.byte-limit";
public static final String
OZONE_OM_RATIS_LOG_APPENDER_QUEUE_BYTE_LIMIT_DEFAULT = "32MB";
+
+ // OM Ratis Pending Write configurations
+ public static final String OZONE_OM_RATIS_PENDING_WRITE_NUM_LIMIT = "ozone.om.ratis.pending.write.num-limit";
+ public static final int OZONE_OM_RATIS_PENDING_WRITE_NUM_LIMIT_DEFAULT = 4096;
Review Comment:
Let's use `element-limit` instead of `num-limit` to standardize with Datanode `DatanodeRatisServerConfig`.
Also we can use `ozone.om.ratis.server` and instead of `ozone.om.ratis.pending` to standardize with the other existing `ozone.om.ratis.server` configuration.
`ozone.om.ratis.pending.write.num-limit` -> `ozone.om.ratis.server.write.element-limit`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org