[jira] [Updated] (UIMA-1906) Daemon thread prevents CPE exit

["Timo Boehme (JIRA)" <de...@uima.apache.org>]

     [ https://issues.apache.org/jira/browse/UIMA-1906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Timo Boehme updated UIMA-1906:
------------------------------
    Attachment: cpm_messages.diff
                CPMEngine.diff

Patch which adds special handling when only daemon threads are left in CPM thread group and system is shutting down.
The patch will wait a specified maximum time (currently 10 seconds; this could be made adjustable) if only threads with daemon state are left in the CPM thread group. After this time the group is set itself to be 'daemon' (enabling Java to release resources as early as possible) and a warning is logged that the group cannot be destroyed.

> Daemon thread prevents CPE exit
> -------------------------------
>
>                 Key: UIMA-1906
>                 URL: https://issues.apache.org/jira/browse/UIMA-1906
>             Project: UIMA
>          Issue Type: Bug
>          Components: Collection Processing
>    Affects Versions: 2.3
>            Reporter: Timo Boehme
>         Attachments: CPMEngine.diff, cpm_messages.diff
>
>
> If a daemon thread was started within an AE and keeps running independent of the AE processing (e.g. bound to a static variable) it prevents exiting of the CPE.
> Simple test:
> add following class to a AE:
> static class DaemonThread implements Runnable {
> 	private static volatile Thread threadInstance;
> 	/** Creates a daemon thread if it not already exists. */
> 	public synchronized static void startThread() {
> 		if ( threadInstance == null ) {
> 			threadInstance = new Thread( new DaemonThread(), "TestDaemon" );
> 			threadInstance.setDaemon( true );
> 			threadInstance.start();
> 		}
> 	}
> 	@Override
> 	public void run() {
> 		while ( true ) {
> 			try { Thread.sleep( 2000 ); } catch ( InterruptedException ie ) {}
> 		}
> 	}
> }
> and call DaemonThread.startThread(); within the process() method.
> After CPE signals collectionProcesscomplete() the application does not exit.
> The reason: in org.apache.uima.collection.impl.cpm.engine.CPMEngine a threadGroupDestroyer thread is created (line 2522) which waits for threads to die. Since it does not check for daemon threads it counts them as normal threads to wait for and thus it waits forever (this can be seen with kill -3 PID to get a JAVA stack trace of all threads under UNIX).
> A workaround would be to put the daemon thread in another ThreadGroup. In the example if you create the tread with
> 			ThreadGroup parent = Thread.currentThread().getThreadGroup();
> 			while ( parent.getParent() != null )
> 				parent = parent.getParent();
> 			threadInstance = new Thread( parent, new DaemonThread(), "TestDaemon" );
> (in the top most thread group)  the CPE exits normally.
> However this is not possible with closed source libraries.
> Thus the threadGroupDestroyer must test for daemon threads. Furthermore the used group.activeCount() (in org.apache.uima.collection.impl.cpm.engine.CPMEngine) should only be used for information purposes - as the javadoc states - not for relying on it as a loop parameter.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)