You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2019/12/18 22:16:50 UTC
[commons-pool] branch master updated: Remove unnecessary array
creation for varargs.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-pool.git
The following commit(s) were added to refs/heads/master by this push:
new b6775ad Remove unnecessary array creation for varargs.
b6775ad is described below
commit b6775ade9fe7862c7ed8852e1c146cd2d4d01ceb
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Wed Dec 18 17:16:46 2019 -0500
Remove unnecessary array creation for varargs.
---
.../java/org/apache/commons/pool2/MethodCall.java | 2 +-
.../org/apache/commons/pool2/TestPoolUtils.java | 24 ++++++----------------
2 files changed, 7 insertions(+), 19 deletions(-)
diff --git a/src/test/java/org/apache/commons/pool2/MethodCall.java b/src/test/java/org/apache/commons/pool2/MethodCall.java
index 768a1d3..dca9c27 100644
--- a/src/test/java/org/apache/commons/pool2/MethodCall.java
+++ b/src/test/java/org/apache/commons/pool2/MethodCall.java
@@ -38,7 +38,7 @@ public class MethodCall {
}
public MethodCall(final String name, final Object param1, final Object param2) {
- this(name, Arrays.asList(new Object[] {param1, param2}));
+ this(name, Arrays.asList(param1, param2));
}
public MethodCall(final String name, final List<Object> params) {
diff --git a/src/test/java/org/apache/commons/pool2/TestPoolUtils.java b/src/test/java/org/apache/commons/pool2/TestPoolUtils.java
index a5fd2a6..f2ba7d2 100644
--- a/src/test/java/org/apache/commons/pool2/TestPoolUtils.java
+++ b/src/test/java/org/apache/commons/pool2/TestPoolUtils.java
@@ -796,11 +796,8 @@ public class TestPoolUtils {
op.returnObject(new Object());
op.toString();
- final List<String> expectedMethods = Arrays.asList(new String[] {
- "addObject", "borrowObject", "clear", "close",
- "getNumActive", "getNumIdle", "invalidateObject",
- "returnObject", "toString"
- });
+ final List<String> expectedMethods = Arrays.asList("addObject", "borrowObject", "clear", "close", "getNumActive", "getNumIdle", "invalidateObject",
+ "returnObject", "toString");
return expectedMethods;
}
@@ -818,11 +815,8 @@ public class TestPoolUtils {
kop.returnObject(null, new Object());
kop.toString();
- final List<String> expectedMethods = Arrays.asList(new String[] {
- "addObject", "borrowObject", "clear", "clear", "close",
- "getNumActive", "getNumActive", "getNumIdle", "getNumIdle", "invalidateObject",
- "returnObject", "toString"
- });
+ final List<String> expectedMethods = Arrays.asList("addObject", "borrowObject", "clear", "clear", "close", "getNumActive", "getNumActive",
+ "getNumIdle", "getNumIdle", "invalidateObject", "returnObject", "toString");
return expectedMethods;
}
@@ -834,10 +828,7 @@ public class TestPoolUtils {
pof.validateObject(null);
pof.toString();
- final List<String> expectedMethods = Arrays.asList(new String[] {
- "activateObject", "destroyObject", "makeObject",
- "passivateObject", "validateObject", "toString",
- });
+ final List<String> expectedMethods = Arrays.asList("activateObject", "destroyObject", "makeObject", "passivateObject", "validateObject", "toString");
return expectedMethods;
}
@@ -849,10 +840,7 @@ public class TestPoolUtils {
kpof.validateObject(null, null);
kpof.toString();
- final List<String> expectedMethods = Arrays.asList(new String[] {
- "activateObject", "destroyObject", "makeObject",
- "passivateObject", "validateObject", "toString",
- });
+ final List<String> expectedMethods = Arrays.asList("activateObject", "destroyObject", "makeObject", "passivateObject", "validateObject", "toString");
return expectedMethods;
}