You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by sp...@apache.org on 2019/09/26 18:27:29 UTC

[tinkerpop] branch master updated: Removed some more side-effect retrieval code - should have been removed some time ago. CTR

This is an automated email from the ASF dual-hosted git repository.

spmallette pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tinkerpop.git


The following commit(s) were added to refs/heads/master by this push:
     new 87e914f  Removed some more side-effect retrieval code - should have been removed some time ago. CTR
87e914f is described below

commit 87e914fe05c01cddfd4147807ef2c4f6be1218e3
Author: Stephen Mallette <sp...@genoprime.com>
AuthorDate: Thu Sep 26 14:26:50 2019 -0400

    Removed some more side-effect retrieval code - should have been removed some time ago. CTR
---
 .../main/jython/gremlin_python/driver/serializer.py   | 19 +------------------
 1 file changed, 1 insertion(+), 18 deletions(-)

diff --git a/gremlin-python/src/main/jython/gremlin_python/driver/serializer.py b/gremlin-python/src/main/jython/gremlin_python/driver/serializer.py
index 1e56e47..8a63f19 100644
--- a/gremlin-python/src/main/jython/gremlin_python/driver/serializer.py
+++ b/gremlin-python/src/main/jython/gremlin_python/driver/serializer.py
@@ -68,23 +68,6 @@ class Traversal(Processor):
         args['aliases'] = aliases
         return args
 
-    def close(self, args):
-        return self.keys(args)
-
-    def gather(self, args):
-        side_effect = uuid.UUID(args['sideEffect'])
-        args['sideEffect'] = self._writer.toDict(side_effect)
-        aliases = args.get('aliases', '')
-        if not aliases:
-            aliases = {'g': 'g'}
-        args['aliases'] = aliases
-        return args
-
-    def keys(self, args):
-        side_effect = uuid.UUID(args['sideEffect'])
-        args['sideEffect'] = self._writer.toDict(side_effect)
-        return args
-
 
 class GraphSONMessageSerializer(object):
     """
@@ -251,7 +234,7 @@ class GraphBinarySerializersV1(object):
             # just works but python 2 bytearray is bound to ByteBufferType so it writes DataType.bytebuffer
             # rather than DataType.bytecode and the server gets confused. special casing this for now until
             # it can be refactored
-            if k == "gremlin" or k == "sideEffect":
+            if k == "gremlin":
                 ba.extend(v)
             else:
                 self._graphbinary_writer.toDict(v, ba)